Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.36.0 #3187

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Release 1.36.0 #3187

merged 1 commit into from
Sep 5, 2024

Conversation

martinhoyer
Copy link
Collaborator

No description provided.

@martinhoyer martinhoyer added this to the 1.36 milestone Sep 4, 2024
@martinhoyer martinhoyer self-assigned this Sep 4, 2024
@martinhoyer martinhoyer added the ci | full test Pull request is ready for the full test execution label Sep 4, 2024
@martinhoyer
Copy link
Collaborator Author

/packit build

@psss psss added the packaging Changes related to the rpm packaging label Sep 4, 2024
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Not many news in the release notes this time, right? I quickly skimmed through the commits and the only thing which might be worth mentioning are the preparations for the subresult support:

32a35b6 Show the subresults and their checks in the HTML report (#3095)
c27aef5 Show subresults and their checks in report display plugin (#3107)
efa026f Rename result phase to subresult

But not sure, probably not worth it when it does not bring anything tangible to the user?

@martinhoyer
Copy link
Collaborator Author

Looks good. Not many news in the release notes this time, right? I quickly skimmed through the commits and the only thing which might be worth mentioning are the preparations for the subresult support:

32a35b6 Show the subresults and their checks in the HTML report (#3095) c27aef5 Show subresults and their checks in report display plugin (#3107) efa026f Rename result phase to subresult

But not sure, probably not worth it when it does not bring anything tangible to the user?

I'm also not sure what's the policy for release notes. My idea is to improve the github release notes and have the rtd release section for items that could do with longer text.
But that's in future, here I think it wouldn't hurt to add a note about the subresults? :)

@psss
Copy link
Collaborator

psss commented Sep 4, 2024

But that's in future, here I think it wouldn't hurt to add a note about the subresults? :)

Feel free to add it or forget about my comment, both is fine from my point of view :)

@martinhoyer
Copy link
Collaborator Author

@psss How does that release note entry look? I assume there isn't any point in letting all the tests finish again just for that?

@psss
Copy link
Collaborator

psss commented Sep 4, 2024

Yeah, looks great! 👍

@martinhoyer martinhoyer merged commit a8603c7 into teemtee:main Sep 5, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci | full test Pull request is ready for the full test execution packaging Changes related to the rpm packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants