-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Targeting command #37
Open
Shom770
wants to merge
10
commits into
main
Choose a base branch
from
targeting-command-with-drivetrain
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forcing reupload Topic: field-frame-drivetrain-2 Relative: refactor-vision-update Reviewers: saraansh, rithvik, pranav
* Use field frame estimator in drivetrain Topic: field-frame-drivetrain-2 Relative: refactor-vision-update Reviewers: saraansh, rithvik, pranav * allow pathfollowing to follow either frame * follow field coordinates in odo frame * set odoTField on command initialize * disallow shifting by odoTField when in field frame * fix var names * working frame irl * frame path following integration * working frame conversions for path following * progress without path planner * working frame following * do proper calculation for applying path transformation * use drivetrain rotation as starting point if one is not provided * assume coordinates are relative to path frame * Enforce check to make sure waypoints match path frames (#33) * enforce check to make sure waypoints match path frames * end command if things don't agree * rename + don't flip odowaypoint * Compile time errors for conflicting waypoints (#35) * enforce check to make sure waypoints match path frames * end command if things don't agree * rename + don't flip odowaypoint * compile time error for conflicting frame path definitions * remove path frame reference * proper naming for these constructors * spotless pls work --------- Co-authored-by: Parth Oza <[email protected]>
sswadkar
requested changes
Feb 21, 2024
src/main/kotlin/com/team4099/robot2023/commands/drivetrain/TargetPoseCommand.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/team4099/robot2023/commands/drivetrain/TargetPoseCommand.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/team4099/robot2023/commands/drivetrain/TargetPoseCommand.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/team4099/robot2023/commands/drivetrain/TargetPoseCommand.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Command that aims the robot at a object in either the field or odometry frame. It allows the driver to still drive around but makes the theta closed loop so it corrects the angle to aim at the object itself. This is useful especially for this year's game when we want to be aimed at the speaker.