-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple english comments, doc changes, and minor changes. #865
Merged
Commits on Oct 14, 2024
-
[simple] Remove deprecated type annotations
Now that we've migrated to a newer version of Python, Optional and Union can be replaced with pipe syntax type hints.
Configuration menu - View commit details
-
Copy full SHA for dbacf3d - Browse repository at this point
Copy the full SHA dbacf3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for de4e390 - Browse repository at this point
Copy the full SHA de4e390View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4946add - Browse repository at this point
Copy the full SHA 4946addView commit details -
One if -> elif. Added a Wtp.warning(). Removed unused function stub.
Configuration menu - View commit details
-
Copy full SHA for ae00728 - Browse repository at this point
Copy the full SHA ae00728View commit details -
[simple] Collect 'head_templates' data
Simple English Wiktionary does not have word head sections like other wiktionaries have, but instead each entry (right after the POS heading) starts with a table or two with the inflection of the word, generated by templates. Instead of making a new field, we collect the name and arguments of these templates and add it to the word entry data under `head_templates`.
Configuration menu - View commit details
-
Copy full SHA for e09e994 - Browse repository at this point
Copy the full SHA e09e994View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a06768 - Browse repository at this point
Copy the full SHA 2a06768View commit details -
I tried to hunt down why Pydantic models would return a `{'': ''}` dict if given an empty dict. Was it because it was a new object, so it wasn't counted as the default? But why would a key-value pair appear, as strings?? Turns out, I was looking at the wrong test, and the problem was in my first test where I had `args={"": ""}` so that I could easily copy-paste everything...
Configuration menu - View commit details
-
Copy full SHA for 7a0cb7a - Browse repository at this point
Copy the full SHA 7a0cb7aView commit details -
Forgot to commit these minor things. Removed some obsolete lines; apparently my LSP doesn't complain about unused global CONST style things, which makes 100% sense.
Configuration menu - View commit details
-
Copy full SHA for ef247b3 - Browse repository at this point
Copy the full SHA ef247b3View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.