Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple english comments, doc changes, and minor changes. #865

Merged
merged 8 commits into from
Oct 14, 2024
Merged

Simple english comments, doc changes, and minor changes. #865

merged 8 commits into from
Oct 14, 2024

Commits on Oct 14, 2024

  1. [simple] Remove deprecated type annotations 

    Now that we've migrated to a newer version of Python,
Optional and Union can be replaced with pipe syntax
type hints.
    @kristian-clausal
    kristian-clausal committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    dbacf3d View commit details
    Browse the repository at this point in the history

  2. [simple] More comments and minor changes

    @kristian-clausal
    kristian-clausal committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    de4e390 View commit details
    Browse the repository at this point in the history

  3. [simple] Comments and docstrings

    @kristian-clausal
    kristian-clausal committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    4946add View commit details
    Browse the repository at this point in the history

  4. [simple] Code clean up 

    One if -> elif.
Added a Wtp.warning().
Removed unused function stub.
    @kristian-clausal
    kristian-clausal committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    ae00728 View commit details
    Browse the repository at this point in the history

  5. [simple] Collect 'head_templates' data 

    Simple English Wiktionary does not have word head sections
like other wiktionaries have, but instead each entry (right
after the POS heading) starts with a table or two with the
inflection of the word, generated by templates.

Instead of making a new field, we collect the name and
arguments of these templates and add it to the word entry
data under `head_templates`.
    @kristian-clausal
    kristian-clausal committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    e09e994 View commit details
    Browse the repository at this point in the history

  6. [simple] Fix bug in error message

    @kristian-clausal
    kristian-clausal committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    2a06768 View commit details
    Browse the repository at this point in the history

  7. [simple] Fix tests 

    I tried to hunt down why Pydantic models would return
a `{'': ''}` dict if given an empty dict. Was it because
it was a new object, so it wasn't counted as the default?
But why would a key-value pair appear, as strings??

Turns out, I was looking at the wrong test, and the problem
was in my first test where I had `args={"": ""}` so that
I could easily copy-paste everything...
    @kristian-clausal
    kristian-clausal committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    7a0cb7a View commit details
    Browse the repository at this point in the history

  8. [simple] Comments, clean-up 

    Forgot to commit these minor things. Removed some obsolete
lines; apparently my LSP doesn't complain about unused global
CONST style things, which makes 100% sense.
    @kristian-clausal
    kristian-clausal committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    ef247b3 View commit details
    Browse the repository at this point in the history