Simple english comments, doc changes, and minor changes. #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we've migrated to a newer version of Python, Optional and Union can be replaced with pipe syntax type hints.
One if -> elif. Added a Wtp.warning(). Removed unused function stub.
Simple English Wiktionary does not have word head sections like other wiktionaries have, but instead each entry (right after the POS heading) starts with a table or two with the inflection of the word, generated by templates. Instead of making a new field, we collect the name and arguments of these templates and add it to the word entry data under `head_templates`.
I tried to hunt down why Pydantic models would return
a `{'': ''}` dict if given an empty dict. Was it because
it was a new object, so it wasn't counted as the default?
But why would a key-value pair appear, as strings??
Turns out, I was looking at the wrong test, and the problem
was in my first test where I had `args={"": ""}` so that
I could easily copy-paste everything...
Forgot to commit these minor things. Removed some obsolete lines; apparently my LSP doesn't complain about unused global CONST style things, which makes 100% sense.
kristian-clausal
force-pushed
the
simple-english
branch
from
fdddec0
to
ef247b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.