Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: propose and mint burnt L1 UTXOs in consensus #1124

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Aug 27, 2024

Description

Proposes burnt UTXOs in local blocks MintConfidentialOutput command
swarm: adds the ability to burn funds on L1 wallet to L2 wallet

Motivation and Context

Previously UTXOs would be recreated as UP if the VN resynced L1. Validators must agree and commit (JMT) to state changes

How Has This Been Tested?

Manually

What process can a PR reviewer use to test or verify this change?

  1. Start swarm
  2. Create an account
  3. Burn funds into the account using swarm
  4. Submit a claim instruction from the L2 wallet
  5. Profit

Breaking Changes

  • None
  • Requires data directory to be deleted
  • Other

BREAKING CHANGE: new command, changes to JSON serialisation that effect the SQLITE db

Copy link

github-actions bot commented Aug 27, 2024

Test Results (CI)

552 tests  +2   552 ✅ +3   1h 28m 35s ⏱️ - 28m 23s
 58 suites ±0     0 💤 ±0 
  2 files   ±0     0 ❌  - 1 

Results for commit 3568548. ± Comparison against base commit 5329042.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@therealdannzor therealdannzor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 👍

@sdbondi sdbondi added this pull request to the merge queue Aug 28, 2024
Merged via the queue into tari-project:development with commit 0da4b32 Aug 28, 2024
13 checks passed
@sdbondi sdbondi deleted the utxo-claiming-fixes branch August 28, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants