fix(consensus)!: defer proposing txs with conflicting unversioned inputs

[sdbondi]

Description

fix(consensus)!: defer proposing txs with conflicting unversioned inputs
refactor: locks take into account if the requested input was versioned or not

Motivation and Context

A transaction may provide an unversioned input. In the multi-shard case, if this input is locked by another transaction, the first transaction should not be proposed until that lock is cleared.

How Has This Been Tested?

Manually, submitting transactions with conflicting unversioned inputs.

What process can a PR reviewer use to test or verify this change?

Submit transactions with transaction_generator and transaction_submitter. The default generated transactions use unversioned inputs.

Breaking Changes

• None
• Requires data directory to be deleted
• Other - Please specify

[github-actions]

Test Results (CI)

553 tests  +1   553 ✅ +1   1h 46m 5s ⏱️ + 17m 59s
 58 suites ±0     0 💤 ±0 
  2 files   ±0     0 ❌ ±0 

Results for commit 256a5b1. ± Comparison against base commit 23bbb44.

This pull request removes 5 and adds 6 tests. Note that renamed tests count towards both.

tari_dan_storage ‑ consensus_models::executed_transaction::export_bindings_versionedsubstateidlockintent
tari_dan_storage ‑ consensus_models::substate::export_bindings_substatelocktype
tari_transaction ‑ substate::export_bindings_substaterequirement
tari_transaction ‑ substate::export_bindings_versionedsubstateid
tari_transaction ‑ substate::tests::it_hashes_identically_to_a_substate_id

tari_dan_common_types ‑ lock_intent::export_bindings_substatelocktype
tari_dan_common_types ‑ versioned_substate_id::export_bindings_substaterequirement
tari_dan_common_types ‑ versioned_substate_id::export_bindings_versionedsubstateid
tari_dan_common_types ‑ versioned_substate_id::tests::it_hashes_identically_to_a_substate_id
tari_dan_storage ‑ consensus_models::lock_intent::export_bindings_substaterequirementlockintent
tari_dan_storage ‑ consensus_models::lock_intent::export_bindings_versionedsubstateidlockintent

♻️ This comment has been updated with latest results.

[therealdannzor]

LGTM, just one minor question