Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for Add-VMGpuPartitionAdapter #269

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: Add support for Add-VMGpuPartitionAdapter #269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89d2fd6
feat: add gpu related fields into the resource & datasource of virtua…
nenkoru May 22, 2024
4b2d27f
feat: add functions to control creating gpu adapter & change the inte…
nenkoru May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
329 changes: 329 additions & 0 deletions api/hyperv-winrm/vm_gpu_adapter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,329 @@
package hyperv_winrm

import (
"context"
"encoding/json"
"log"
"text/template"

"github.com/taliesins/terraform-provider-hyperv/api"
)

type createVmGpuAdapterArgs struct {
VMName string
VmGpuAdapterJson string
}

var createVmGpuAdapterTemplate = template.Must(template.New("CreateVmGpuAdapter").Parse(`
$ErrorActionPreference = 'Stop'
$vmGpuAdapter = '{{.VmGpuAdapterJson}}' | ConvertFrom-Json


$NewVmGpuAdapterArgs = @{
InstancePath=$vmGpuAdapter.InstancePath
}

@(Get-VM -Name '{{.VMName}}') | Add-VMGpuPartitionAdapter @NewVmGpuAdapterArgs

$SetVmGpuAdapterArgs = @{
MinPartitionVRAM=$vmGpuAdapter.MinPartitionVRAM
MaxPartitionVRAM=$vmGpuAdapter.MaxPartitionVRAM
OptimalPartitionVRAM=$vmGpuAdapter.OptimalPartitionVRAM

MinPartitionEncode=$vmGpuAdapter.MinPartitionEncode
MaxPartitionEncode=$vmGpuAdapter.MaxPartitionEncode
OptimalPartitionEncode=$vmGpuAdapter.OptimalPartitionEncode

MinPartitionDecode=$vmGpuAdapter.MinPartitionDecode
MaxPartitionDecode=$vmGpuAdapter.MaxPartitionDecode
OptimalPartitionDecode=$vmGpuAdapter.OptimalPartitionDecode

MinPartitionCompute=$vmGpuAdapter.MinPartitionCompute
MaxPartitionCompute=$vmGpuAdapter.MaxPartitionCompute
OptimalPartitionCompute=$vmGpuAdapter.OptimalPartitionCompute

}

@(Get-VM -Name '{{.VMName}}' | Get-VMGpuPartitionAdapter | ?{$_.InstancePath -eq $vmGpuAdapter.InstancePath }) | Set-VMGpuPartitionAdapter @SetVmGpuAdapterArgs

`))

func (c *ClientConfig) CreateVmGpuAdapter(
ctx context.Context,
vmName string,
instancePath string,
minPartitionVram int32,
maxPartitionVram int32,
optimalPartitionVram int32,
minPartitionEncode int64,
maxPartitionEncode int64,
optimalPartitionEncode int64,
minPartitionDecode int32,
maxPartitionDecode int32,
optimalPartitionDecode int32,
minPartitionCompute int32,
maxPartitionCompute int32,
optimalPartitionCompute int32,
) (err error) {
vmGpuAdapterJson, err := json.Marshal(api.VmGpuAdapter{
VmName: vmName,
InstancePath: instancePath,
MinPartitionVram: minPartitionVram,
MaxPartitionVram: maxPartitionVram,
OptimalPartitionVram: optimalPartitionVram,
MinPartitionEncode: minPartitionEncode,
MaxPartitionEncode: maxPartitionEncode,
OptimalPartitionEncode: optimalPartitionEncode,
MinPartitionDecode: minPartitionDecode,
MaxPartitionDecode: maxPartitionDecode,
OptimalPartitionDecode: optimalPartitionDecode,
MinPartitionCompute: minPartitionCompute,
MaxPartitionCompute: maxPartitionCompute,
OptimalPartitionCompute: optimalPartitionCompute,
})

if err != nil {
return err
}

err = c.WinRmClient.RunFireAndForgetScript(ctx, createVmGpuAdapterTemplate, createVmGpuAdapterArgs{
VMName: vmName,
VmGpuAdapterJson: string(vmGpuAdapterJson),
})

return err
}

type getVmGpuAdaptersArgs struct {
VmName string
}

var getVmGpuAdaptersTemplate = template.Must(template.New("GetVmGpuAdapters").Parse(`
$vmGpuAdaptersObject = @(Get-VM -Name '{{.VmName}}*' | ?{$_.Name -eq '{{.VmName}}' } | Get-VMGpuPartitionAdapter | %{ @{
InstancePath=$_.InstancePath;

CurrentPartitionVRAM=$_.CurrentPartitionVRAM;
MinPartitionVRAM=$_.MinPartitionVRAM;
MaxPartitionVRAM=$_.MaxPartitionVRAM;
OptimalPartitionVRAM=$_.OptimalPartitionVRAM;

CurrentPartitionEncode=$_.CurrentPartitionEncode;
MinPartitionEncode=$_.MinPartitionEncode;
MaxPartitionEncode=$_.MaxPartitionEncode;
OptimalPartitionEncode=$_.OptimalPartitionEncode;

CurrentPartitionDecode=$_.CurrentPartitionDecode;
MinPartitionDecode=$_.MinPartitionDecode;
MaxPartitionDecode=$_.MaxPartitionDecode;
OptimalPartitionDecode=$_.OptimalPartitionDecode;

CurrentPartitionCompute=$_.CurrentPartitionCompute;
MinPartitionCompute=$_.MinPartitionCompute;
MaxPartitionCompute=$_.MaxPartitionCompute;
OptimalPartitionCompute=$_.OptimalPartitionCompute;

}})

if ($vmGpuAdaptersObject) {
# unexpectedly, powershell replaces & wit the unicode representation, so it has to be replaced back
$vmGpuAdapters = (ConvertTo-Json -InputObject $vmGpuAdaptersObject) -replace '\\u0026', '&'
$vmGpuAdapters
} else {
"[]"
}
`))

func (c *ClientConfig) GetVmGpuAdapters(ctx context.Context, vmName string) (result []api.VmGpuAdapter, err error) {
result = make([]api.VmGpuAdapter, 0)

err = c.WinRmClient.RunScriptWithResult(ctx, getVmGpuAdaptersTemplate, getVmGpuAdaptersArgs{
VmName: vmName,
}, &result)

return result, err
}

type updateVmGpuAdapterArgs struct {
VmName string
InstancePath string
VmGpuAdapterJson string
}

var updateVmGpuAdapterTemplate = template.Must(template.New("UpdateVmGpuAdapter").Parse(`
$ErrorActionPreference = 'Stop'
Import-Module Hyper-V
$vmGpuAdapter = '{{.VmGpuAdapterJson}}' | ConvertFrom-Json

$vmGpuAdaptersObject = @(Get-VM -Name '{{.VmName}}*' | ?{$_.Name -eq '{{.VmName}}' } | Get-VMGpuPartitionAdapter | ?{$_.InstancePath -eq '{{.InstancePath}}' })

if (!$vmGpuAdaptersObject){
throw "VM gpu adapter does not exist - {{.InstancePath}}"
}


$SetVmGpuAdapterArgs = @{
MinPartitionVRAM=$vmGpuAdapter.MinPartitionVRAM
MaxPartitionVRAM=$vmGpuAdapter.MaxPartitionVRAM
OptimalPartitionVRAM=$vmGpuAdapter.OptimalPartitionVRAM

MinPartitionEncode=$vmGpuAdapter.MinPartitionEncode
MaxPartitionEncode=$vmGpuAdapter.MaxPartitionEncode
OptimalPartitionEncode=$vmGpuAdapter.OptimalPartitionEncode

MinPartitionDecode=$vmGpuAdapter.MinPartitionDecode
MaxPartitionDecode=$vmGpuAdapter.MaxPartitionDecode
OptimalPartitionDecode=$vmGpuAdapter.OptimalPartitionDecode

MinPartitionCompute=$vmGpuAdapter.MinPartitionCompute
MaxPartitionCompute=$vmGpuAdapter.MaxPartitionCompute
OptimalPartitionCompute=$vmGpuAdapter.OptimalPartitionCompute

}

@(Get-VM -Name '{{.VmName}}' | Get-VMGpuPartitionAdapter | ?{$_.InstancePath -eq $vmGpuAdapter.InstancePath }) | Set-VMGpuPartitionAdapter @SetVmGpuAdapterArgs
`))

func (c *ClientConfig) UpdateVmGpuAdapter(
ctx context.Context,
vmName string,
instancePath string,
minPartitionVram int32,
maxPartitionVram int32,
optimalPartitionVram int32,
minPartitionEncode int64,
maxPartitionEncode int64,
optimalPartitionEncode int64,
minPartitionDecode int32,
maxPartitionDecode int32,
optimalPartitionDecode int32,
minPartitionCompute int32,
maxPartitionCompute int32,
optimalPartitionCompute int32,
) (err error) {
vmGpuAdapterJson, err := json.Marshal(api.VmGpuAdapter{
VmName: vmName,
InstancePath: instancePath,
MinPartitionVram: minPartitionVram,
MaxPartitionVram: maxPartitionVram,
OptimalPartitionVram: optimalPartitionVram,
MinPartitionEncode: minPartitionEncode,
MaxPartitionEncode: maxPartitionEncode,
OptimalPartitionEncode: optimalPartitionEncode,
MinPartitionDecode: minPartitionDecode,
MaxPartitionDecode: maxPartitionDecode,
OptimalPartitionDecode: optimalPartitionDecode,
MinPartitionCompute: minPartitionCompute,
MaxPartitionCompute: maxPartitionCompute,
OptimalPartitionCompute: optimalPartitionCompute,
})

if err != nil {
return err
}

err = c.WinRmClient.RunFireAndForgetScript(ctx, updateVmGpuAdapterTemplate, updateVmGpuAdapterArgs{
VmName: vmName,
InstancePath: instancePath,
VmGpuAdapterJson: string(vmGpuAdapterJson),
})

return err
}

type deleteVmGpuAdapterArgs struct {
VmName string
InstancePath string
}

var deleteVmGpuAdapterTemplate = template.Must(template.New("DeleteVmGpuAdapter").Parse(`
$ErrorActionPreference = 'Stop'

@(Get-VM -Name '{{.VmName}}*' | ?{$_.Name -eq '{{.VmName}}' } | Get-VMGpuPartitionAdapter | ?{$_.InstancePath -eq '{{.InstancePath}}' }) | Remove-VMGpuPartitionAdapter
`))

func (c *ClientConfig) DeleteVmGpuAdapter(ctx context.Context, vmName string, instancePath string) (err error) {
err = c.WinRmClient.RunFireAndForgetScript(ctx, deleteVmGpuAdapterTemplate, deleteVmGpuAdapterArgs{
VmName: vmName,
InstancePath: instancePath,
})

return err
}

func (c *ClientConfig) CreateOrUpdateVmGpuAdapters(ctx context.Context, vmName string, gpuAdapters []api.VmGpuAdapter) (err error) {
currentGpuAdapters, err := c.GetVmGpuAdapters(ctx, vmName)
if err != nil {
return err
}

currentGpuAdaptersLength := len(currentGpuAdapters)
desiredGpuAdaptersLength := len(gpuAdapters)

log.Printf("currentGpuAdaptersLength: %d", currentGpuAdaptersLength)
log.Printf("desiredGpuAdaptersLength: %d", desiredGpuAdaptersLength)

for i := currentGpuAdaptersLength - 1; i > desiredGpuAdaptersLength-1; i-- {
currentGpuAdapter := currentGpuAdapters[i]
err = c.DeleteVmGpuAdapter(ctx, vmName, currentGpuAdapter.InstancePath)
if err != nil {
return err
}
}

if currentGpuAdaptersLength > desiredGpuAdaptersLength {
currentGpuAdaptersLength = desiredGpuAdaptersLength
}

for i := 0; i <= currentGpuAdaptersLength-1; i++ {
currentGpuAdapter := currentGpuAdapters[i]
gpuAdapter := gpuAdapters[i]

err = c.UpdateVmGpuAdapter(
ctx,
vmName,
currentGpuAdapter.InstancePath,
gpuAdapter.MinPartitionVram,
gpuAdapter.MaxPartitionVram,
gpuAdapter.OptimalPartitionVram,
gpuAdapter.MinPartitionEncode,
gpuAdapter.MaxPartitionEncode,
gpuAdapter.OptimalPartitionEncode,
gpuAdapter.MinPartitionDecode,
gpuAdapter.MaxPartitionDecode,
gpuAdapter.OptimalPartitionDecode,
gpuAdapter.MinPartitionCompute,
gpuAdapter.MaxPartitionCompute,
gpuAdapter.OptimalPartitionCompute,
)
if err != nil {
return err
}
}

for i := currentGpuAdaptersLength - 1 + 1; i <= desiredGpuAdaptersLength-1; i++ {
gpuAdapter := gpuAdapters[i]
err = c.CreateVmGpuAdapter(
ctx,
vmName,
gpuAdapter.InstancePath,
gpuAdapter.MinPartitionVram,
gpuAdapter.MaxPartitionVram,
gpuAdapter.OptimalPartitionVram,
gpuAdapter.MinPartitionEncode,
gpuAdapter.MaxPartitionEncode,
gpuAdapter.OptimalPartitionEncode,
gpuAdapter.MinPartitionDecode,
gpuAdapter.MaxPartitionDecode,
gpuAdapter.OptimalPartitionDecode,
gpuAdapter.MinPartitionCompute,
gpuAdapter.MaxPartitionCompute,
gpuAdapter.OptimalPartitionCompute,
)

if err != nil {
return err
}
}

return nil
}
1 change: 1 addition & 0 deletions api/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ type Client interface {
HypervVmIntegrationServiceClient
HypervVmNetworkAdapterClient
HypervVmProcessorClient
HypervGpuAdapterClient
HypervVmStatusClient
HypervVmSwitchClient
HypervIsoImageClient
Expand Down
Loading