feat: Add support for Add-VMGpuPartitionAdapter #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nenkoru
changed the title
|
Works fine for me, tested a couple of times with different cases except for the data source |
…rface to comply with the int64 requirement for encode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #268
Opted for InstancePath selection instead of by name of the gpu adapter considering the case when there could be two identical gpu adapters with the same name on the host machine. Eg 2x3090 or so.
all the info regarding scripts could be found in this gist [1]
[1] https://gist.github.com/nenkoru/acadf3039c94525f3bc3a7329cfdfcd1
also opted-out of copying the driver into the virtual machine as I think it is out of scope of this project