Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(420): integrated more reasons section #422

Merged
merged 25 commits into from
Aug 15, 2024
Merged

feat(420): integrated more reasons section #422

merged 25 commits into from
Aug 15, 2024

Conversation

mehulmathur16
Copy link
Contributor

@mehulmathur16 mehulmathur16 commented Aug 4, 2024 •
edited by amitksingh1490
Loading

/claim #420
fixes #420

@algora-pbc algora-pbc bot mentioned this pull request Aug 4, 2024
Closed
tusharmath
tusharmath reviewed Aug 11, 2024
View reviewed changes
src/constants/index.tsx Outdated Show resolved Hide resolved
tusharmath
tusharmath reviewed Aug 11, 2024
View reviewed changes
src/constants/index.tsx Outdated Show resolved Hide resolved
tusharmath
tusharmath reviewed Aug 11, 2024
View reviewed changes
src/constants/index.tsx Outdated Show resolved Hide resolved
@tusharmath tusharmath marked this pull request as draft August 11, 2024 10:23
@mehulmathur16 mehulmathur16 marked this pull request as ready for review August 11, 2024 11:03
@mehulmathur16 mehulmathur16 changed the title chore: integrated more reasons section [420] chore: integrated more reasons section Aug 11, 2024
@mehulmathur16 mehulmathur16 changed the title [420] chore: integrated more reasons section [ISSUE_420] chore: integrated more reasons section Aug 11, 2024
@tusharmath tusharmath changed the title [ISSUE_420] chore: integrated more reasons section docs[ISSUE_420] chore: integrated more reasons section Aug 11, 2024
@tusharmath tusharmath changed the title docs[ISSUE_420] chore: integrated more reasons section docs(ISSUE_420): integrated more reasons section Aug 11, 2024
@tusharmath tusharmath changed the title docs(ISSUE_420): integrated more reasons section feat(ISSUE_420): integrated more reasons section Aug 11, 2024
@tusharmath tusharmath changed the title feat(ISSUE_420): integrated more reasons section feat(420): integrated more reasons section Aug 11, 2024
@tusharmath
Copy link
Contributor

Design Feedback

  1. Mismatch in border radius
  2. Mismatch in border width
  3. Mismatch in width of view more button

@tusharmath tusharmath marked this pull request as draft August 11, 2024 12:06
@tusharmath
Copy link
Contributor

Moving to draft to reduce noise and improve CI efficiency. Once you are ready just mark it as "ready to review". Feel free to give a shoutout on the #contributors channel on Discord if you want immediate attention.

@tusharmath tusharmath mentioned this pull request Aug 11, 2024
Closed
@mehulmathur16 mehulmathur16 marked this pull request as ready for review August 11, 2024 13:27
@tusharmath
Copy link
Contributor

Border Clipped
Screenshot 2024-08-13 at 10 53 14 AM

Border Width Mismatch at various places on the website
Screenshot 2024-08-13 at 10 53 46 AM

@tusharmath tusharmath marked this pull request as draft August 13, 2024 06:09
@mehulmathur16 mehulmathur16 marked this pull request as ready for review August 13, 2024 16:32
@tusharmath tusharmath merged commit 2813c68 into develop Aug 15, 2024
3 checks passed
@tusharmath tusharmath deleted the more-reasons branch August 15, 2024 10:51
@tusharmath
Copy link
Contributor

/tip 20$

@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Aug 15, 2024

🎉🎈 @mehulmathur16 has been awarded $20! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tusharmath tusharmath Awaiting requested review from tusharmath

Assignees
No one assigned
Labels
🙋 Bounty claim 💰 Rewarded
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the features section to home page
2 participants
@mehulmathur16 @tusharmath