Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added features section #428

Closed
wants to merge 13 commits into from
Closed

Conversation

Oms-343
Copy link

@Oms-343 Oms-343 commented Aug 5, 2024

/claim #420

what my code did ➡️

  1. implemented styles for two screens (mobile and desktop) based on the figma file (used mobile first approach)
  2. utilized existing spacing and colors from the tailwind config rather than arbitary styles
  3. implementation is almost pixel perfect to figma design

what might be the red flags in my code ➡️

  1. since i was not able to modify the svg color by css , i had to change the color of svg elements in their respective files
  2. Tablet design or extreme wide screen may contain inconsistency as i focused on only the figma mentioned designs (reason : since the bounty is not assigned to me at the moment , and thus this extra work can go in vain

what would be the improvments in my code ➡️

  1. Adding styles for medium-sized device (tablets) and widescreen
  2. adding some sleek animation around the borders

here is the video of the implemented design
https://www.loom.com/share/cbd480bdd27f430786c514000848ee9b?sid=7280f161-35f0-4179-94c4-18c5accc95eb

Copy link

algora-pbc bot commented Aug 5, 2024

💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe.

@Oms-343
Copy link
Author

Oms-343 commented Aug 6, 2024

hello @tusharmath can you review this PR if possible. 👍

@tusharmath
Copy link
Contributor

thanks @Oms-343!
Closing in favour of #422

@tusharmath tusharmath closed this Aug 11, 2024
@Oms-343
Copy link
Author

Oms-343 commented Aug 11, 2024

thanks @Oms-343! Closing in favour of #422

ok thanks for the update 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants