Annihilate reconciliation func remnants #4454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-sdf
nickgerace
force-pushed
the
nick/eng-2653
branch
from
3e57c36 to
b87a23d
Compare
nickgerace
force-pushed
the
nick/eng-2653
branch
from
b87a23d to
47ff33d
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This commit removes remnants of reconciliation funcs in the codebase. Since they are unused and since their re-introduction would likely take a different shape, we are destroying what remains. We loved you! Signed-off-by: Nick Gerace <[email protected]>
nickgerace
force-pushed
the
nick/eng-2653
branch
from
47ff33d to
a38bc68
Compare
nickgerace
added a commit
that referenced
this pull request
Sep 9, 2024
This commit removes remnants of reconciliation funcs in the codebase. Since they are unused and since their re-introduction would likely take a different shape, we are destroying what remains. We loved you! This is a second attempt (#4523 and #4454) and now works with existing graphs due to deserializing enums that contained reconciliation funcs. Signed-off-by: Nick Gerace <[email protected]>
nickgerace
added a commit
that referenced
this pull request
Sep 10, 2024
This commit removes remnants of reconciliation funcs in the codebase. Since they are unused and since their re-introduction would likely take a different shape, we are destroying what remains. We loved you! This is a second attempt (#4523 and #4454) and now works with existing graphs due to deserializing enums that contained reconciliation funcs. Signed-off-by: Nick Gerace <[email protected]>
nickgerace
added a commit
that referenced
this pull request
Sep 10, 2024
This commit removes remnants of reconciliation funcs in the codebase. Since they are unused and since their re-introduction would likely take a different shape, we are destroying what remains. We loved you! This is a second attempt (#4523 and #4454) and now works with existing graphs due to deserializing enums that contained reconciliation funcs. Signed-off-by: Nick Gerace <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes remnants of reconciliation funcs in the codebase. Since they are unused and since their re-introduction would likely take a different shape, we are destroying what remains. We loved you!