Annihilate reconciliation func remnants

This commit removes remnants of reconciliation funcs in the codebase. Since they are unused and since their re-introduction would likely take a different shape, we are destroying what remains. We loved you! Signed-off-by: Nick Gerace <[email protected]>
systeminit · Sep 7, 2024 · 47ff33d · 47ff33d
1 parent 1de0c1a
commit 47ff33d
Show file tree

Hide file tree

Showing 33 changed files with 21 additions and 878 deletions.
diff --git a/app/web/src/store/func_runs.store.ts b/app/web/src/store/func_runs.store.ts
@@ -44,7 +44,6 @@ export enum FuncBackendKind {
   JsAttribute,
   JsAuthentication,
   Json,
-  JsReconciliation,
   JsSchemaVariantDefinition,
   JsValidation,
   Map,
@@ -65,7 +64,6 @@ export enum FuncBackendResponseType {
   Map,
   Object,
   Qualification,
-  Reconciliation,
   SchemaVariantDefinition,
   String,
   Unset,

diff --git a/bin/cyclone/src/args.rs b/bin/cyclone/src/args.rs
@@ -107,14 +107,6 @@ pub(crate) struct Args {
     #[arg(long, group = "action_run")]
     pub(crate) disable_action_run: bool,
 
-    /// Enables reconciliation endpoint.
-    #[arg(long, group = "reconciliation")]
-    pub(crate) enable_reconciliation: bool,
-
-    /// Disables reconciliation endpoint.
-    #[arg(long, group = "reconciliation")]
-    pub(crate) disable_reconciliation: bool,
-
     /// Enables configuration endpoint.
     #[arg(long, group = "configuration")]
     pub(crate) enable_configuration: bool,

diff --git a/bin/lang-js/src/function.ts b/bin/lang-js/src/function.ts
@@ -8,9 +8,6 @@ import joi_validation, {
   JoiValidationFunc,
   JoiValidationResult,
 } from "./function_kinds/joi_validation";
-import reconciliation, {
-  ReconciliationFunc,
-} from "./function_kinds/reconciliation";
 import resolver_function, {
   ResolverFunc,
 } from "./function_kinds/resolver_function";
@@ -27,7 +24,6 @@ export enum FunctionKind {
   Before = "before",
   ResolverFunction = "resolverfunction",
   Validation = "validation",
-  Reconciliation = "reconciliation",
   SchemaVariantDefinition = "schemaVariantDefinition",
 }
 
@@ -126,15 +122,6 @@ export async function executeFunction(kind: FunctionKind, request: Request, time
         }),
       );
 
-      break;
-    case FunctionKind.Reconciliation:
-      result = await executor(
-        ctx,
-        request as ReconciliationFunc,
-        kind,
-        timeout,
-        reconciliation,
-      );
       break;
     case FunctionKind.ResolverFunction:
       result = await executor(

diff --git a/bin/lang-js/src/function_kinds/reconciliation.ts b/bin/lang-js/src/function_kinds/reconciliation.ts
diff --git a/bin/lang-js/src/request.ts b/bin/lang-js/src/request.ts
@@ -1,7 +1,6 @@
 import { ActionRunFunc } from "./function_kinds/action_run";
 import { BeforeFunc } from "./function_kinds/before";
 import { JoiValidationFunc } from "./function_kinds/joi_validation";
-import { ReconciliationFunc } from "./function_kinds/reconciliation";
 import { ResolverFunc } from "./function_kinds/resolver_function";
 import {
   SchemaVariantDefinitionFunc,
@@ -11,7 +10,6 @@ export type AnyFunction =
   | ActionRunFunc
   | JoiValidationFunc
   | BeforeFunc
-  | ReconciliationFunc
   | ResolverFunc
   | SchemaVariantDefinitionFunc;