Skip to content

Commit

Permalink
🌱 Remove permanent error after bm reboot (#1396)
Browse files Browse the repository at this point in the history
In the provisioning of bare metal servers, we added permanent errors
that appear after a server times out while rebooting.

This turned out to be quite unreliable, because the server reboots are
very unreliable. Sometimes they take forever to reboot, in other
situations they are fast and the server provisions successfully.

Therefore, we should rather try again and not stop completely.
  • Loading branch information
janiskemper authored Jul 25, 2024
1 parent d3bd5b5 commit 475cb3a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/services/baremetal/host/host.go
Original file line number Diff line number Diff line change
Expand Up @@ -1317,7 +1317,7 @@ func (s *Service) actionProvisioning() actionResult {
}
failed, err := s.handleIncompleteBoot(false, isSSHTimeoutError, isSSHConnectionRefusedError)
if failed {
return s.recordActionFailure(infrav1.PermanentError, err.Error())
return s.recordActionFailure(infrav1.ProvisioningError, err.Error())
}
if err != nil {
return actionError{err: fmt.Errorf(errMsgFailedHandlingIncompleteBoot, err)}
Expand Down Expand Up @@ -1506,7 +1506,7 @@ func (s *Service) actionEnsureProvisioned() (ar actionResult) {

failed, err := s.handleIncompleteBoot(false, isTimeout, isSSHConnectionRefusedError)
if failed {
return s.recordActionFailure(infrav1.PermanentError, err.Error())
return s.recordActionFailure(infrav1.ProvisioningError, err.Error())
}
if err != nil {
return actionError{err: fmt.Errorf(errMsgFailedHandlingIncompleteBoot, err)}
Expand Down

0 comments on commit 475cb3a

Please sign in to comment.