🌱 Set condition to false if server resource unavailable (#1394)

set condition to false if server resource unavailable mark hcloud machine's "serverCreateSucceeded" condition to false if it throws server resource unavailable error Signed-off-by: Dhairya Arora <[email protected]>
syself · Jul 25, 2024 · d3bd5b5 · d3bd5b5
1 parent e21e3b2
commit d3bd5b5
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 6 deletions.
diff --git a/api/v1beta1/conditions_const.go b/api/v1beta1/conditions_const.go
@@ -48,6 +48,10 @@ const (
  ServerLimitExceededReason = "ServerLimitExceeded"
  // ServerTypeNotFoundReason indicates that server type could not be found.
  ServerTypeNotFoundReason = "ServerTypeNotFound"
+ // ServerResourceUnavailableReason indicates that server resource is unavailable.
+ ServerResourceUnavailableReason = "ServerResourceUnavailable"
+ // ServerPlacementErrorReason indicates placement error while creating server.
+ ServerPlacementErrorReason = "ServerPlacementError"
 )
 
 const (

diff --git a/pkg/services/hcloud/server/server.go b/pkg/services/hcloud/server/server.go
@@ -459,14 +459,34 @@ func (s *Service) createServer(ctx context.Context) (*hcloud.Server, error) {
  clusterv1.ConditionSeverityError,
  err.Error(),
  )
- record.Warnf(s.scope.HCloudMachine,
- "FailedCreateHCloudServer",
- "Failed to create HCloud server %s: %s",
- s.scope.Name(),
- err,
+
+ err = errors.Join(errServerCreateNotPossible, err)
+ }
+
+ if hcloud.IsError(err, hcloud.ErrorCodeResourceUnavailable) {
+ conditions.MarkFalse(
+ s.scope.HCloudMachine,
+ infrav1.ServerCreateSucceededCondition,
+ infrav1.ServerResourceUnavailableReason,
+ clusterv1.ConditionSeverityWarning,
+ err.Error(),
  )
- return nil, errServerCreateNotPossible
+
+ err = errors.Join(errServerCreateNotPossible, err)
  }
+
+ if hcloud.IsError(err, hcloud.ErrorCodePlacementError) {
+ conditions.MarkFalse(
+ s.scope.HCloudMachine,
+ infrav1.ServerCreateSucceededCondition,
+ infrav1.ServerPlacementErrorReason,
+ clusterv1.ConditionSeverityWarning,
+ err.Error(),
+ )
+
+ err = errors.Join(errServerCreateNotPossible, err)
+ }
+
  record.Warnf(s.scope.HCloudMachine,
  "FailedCreateHCloudServer",
  "Failed to create HCloud server %s: %s",