Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update projects.yml #3

Open
wants to merge 1 commit into
base: symfony_cmf
Choose a base branch
from
Open

Update projects.yml #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion config/projects.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,7 @@ testing:
docs_path: 'components/testing'
deprecation_warnings: "/.*each.*/"
php: ['7.1', '7.2']
phpunit_version: 6.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have something, what renders that information to the right places? You should edit the templates too then.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i expected this to be translated to

dev-kit/project/.travis.yml.twig

Line 41 in f114ea7

- SYMFONY_PHPUNIT_VERSION={{ phpunit_version }}
- am i wrong with that assumption?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be correct, can your run it for testing lokal without pushing it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately not: ./dev-kit dispatch --with-files testing

Files for master
----------------

diff --git a/composer.json b/composer.json
index de4cb3b..085c9ef 100644
--- a/composer.json
+++ b/composer.json
@@ -18,22 +18,22 @@
         "friendsofsymfony/jsrouting-bundle": "^1.1 || ^2.1",
         "jackalope/jackalope": "^1.3",
         "jackalope/jackalope-doctrine-dbal": "^1.3",
-        "symfony/browser-kit": "^2.8 || ^3.0 || ^4.0",
-        "symfony/console": "^2.8 || ^3.0 || ^4.0",
-        "symfony/css-selector": "^2.8 || ^3.0 || ^4.0",
-        "symfony/debug": "^2.8 || ^3.0 || ^4.0",
-        "symfony/dependency-injection": "^2.8 || ^3.0 || ^4.0",
-        "symfony/doctrine-bridge": "^2.8 || ^3.0 || ^4.0",
-        "symfony/framework-bundle": "^2.8.1 || ^3.0 || ^4.0",
-        "symfony/http-foundation": "^2.8 || ^3.0 || ^4.0",
-        "symfony/http-kernel": "^2.8 || ^3.0 || ^4.0",
-        "symfony/monolog-bundle": "^3.1",
-        "symfony/process": "^2.8 || ^3.0 || ^4.0",
-        "symfony/security-bundle": "^2.8 || ^3.0 || ^4.0",
-        "symfony/twig-bundle": "^2.8 || ^3.0 || ^4.0"
+        "symfony/browser-kit": "^2.8 || ^3.3 || ^4.0",
+        "symfony/console": "^2.8 || ^3.3 || ^4.0",
+        "symfony/css-selector": "^2.8 || ^3.3 || ^4.0",
+        "symfony/debug": "^2.8 || ^3.3 || ^4.0",
+        "symfony/dependency-injection": "^2.8 || ^3.3 || ^4.0",
+        "symfony/doctrine-bridge": "^2.8 || ^3.3 || ^4.0",
+        "symfony/framework-bundle": "^2.8 || ^3.3 || ^4.0",
+        "symfony/http-foundation": "^2.8 || ^3.3 || ^4.0",
+        "symfony/http-kernel": "^2.8 || ^3.3 || ^4.0",
+        "symfony/monolog-bundle": "~3.1",
+        "symfony/process": "^2.8 || ^3.3 || ^4.0",
+        "symfony/security-bundle": "^2.8 || ^3.3 || ^4.0",
+        "symfony/twig-bundle": "^2.8 || ^3.3 || ^4.0"
     },
     "require-dev": {
-        "symfony/phpunit-bridge": "^4.0"
+        "symfony/phpunit-bridge": "^3.3 || ^4.0"
     },
     "autoload": {
         "psr-4": {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall i do that for you on our "master"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you have the time to do so, yes please

make_tasks:
unit_tests: ~
versions:
Expand All @@ -284,4 +285,4 @@ tree-browser-bundle:
unit_tests: ~
test_installation: ~
versions:
symfony: ['2.8.*', '3.3', '3.4.*', '4.0.*']
symfony: ['2.8.*', '3.3', '3.4.*', '4.0.*']