Update projects.yml #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElectricMaxxx
requested changes
Feb 27, 2018
| @@ -264,6 +264,7 @@ testing: | |||
| docs_path: 'components/testing' | |||
| deprecation_warnings: "/.*each.*/" | |||
| php: ['7.1', '7.2'] | |||
| phpunit_version: 6.5 | |||
There was a problem hiding this comment.
do we have something, what renders that information to the right places? You should edit the templates too then.
There was a problem hiding this comment.
i expected this to be translated to
dev-kit/project/.travis.yml.twig
Line 41 in f114ea7
There was a problem hiding this comment.
Could be correct, can your run it for testing lokal without pushing it?
There was a problem hiding this comment.
unfortunately not: ./dev-kit dispatch --with-files testing
Files for master
----------------
diff --git a/composer.json b/composer.json
index de4cb3b..085c9ef 100644
--- a/composer.json
+++ b/composer.json
@@ -18,22 +18,22 @@
"friendsofsymfony/jsrouting-bundle": "^1.1 || ^2.1",
"jackalope/jackalope": "^1.3",
"jackalope/jackalope-doctrine-dbal": "^1.3",
- "symfony/browser-kit": "^2.8 || ^3.0 || ^4.0",
- "symfony/console": "^2.8 || ^3.0 || ^4.0",
- "symfony/css-selector": "^2.8 || ^3.0 || ^4.0",
- "symfony/debug": "^2.8 || ^3.0 || ^4.0",
- "symfony/dependency-injection": "^2.8 || ^3.0 || ^4.0",
- "symfony/doctrine-bridge": "^2.8 || ^3.0 || ^4.0",
- "symfony/framework-bundle": "^2.8.1 || ^3.0 || ^4.0",
- "symfony/http-foundation": "^2.8 || ^3.0 || ^4.0",
- "symfony/http-kernel": "^2.8 || ^3.0 || ^4.0",
- "symfony/monolog-bundle": "^3.1",
- "symfony/process": "^2.8 || ^3.0 || ^4.0",
- "symfony/security-bundle": "^2.8 || ^3.0 || ^4.0",
- "symfony/twig-bundle": "^2.8 || ^3.0 || ^4.0"
+ "symfony/browser-kit": "^2.8 || ^3.3 || ^4.0",
+ "symfony/console": "^2.8 || ^3.3 || ^4.0",
+ "symfony/css-selector": "^2.8 || ^3.3 || ^4.0",
+ "symfony/debug": "^2.8 || ^3.3 || ^4.0",
+ "symfony/dependency-injection": "^2.8 || ^3.3 || ^4.0",
+ "symfony/doctrine-bridge": "^2.8 || ^3.3 || ^4.0",
+ "symfony/framework-bundle": "^2.8 || ^3.3 || ^4.0",
+ "symfony/http-foundation": "^2.8 || ^3.3 || ^4.0",
+ "symfony/http-kernel": "^2.8 || ^3.3 || ^4.0",
+ "symfony/monolog-bundle": "~3.1",
+ "symfony/process": "^2.8 || ^3.3 || ^4.0",
+ "symfony/security-bundle": "^2.8 || ^3.3 || ^4.0",
+ "symfony/twig-bundle": "^2.8 || ^3.3 || ^4.0"
},
"require-dev": {
- "symfony/phpunit-bridge": "^4.0"
+ "symfony/phpunit-bridge": "^3.3 || ^4.0"
},
"autoload": {
"psr-4": {
There was a problem hiding this comment.
Shall i do that for you on our "master"?
There was a problem hiding this comment.
if you have the time to do so, yes please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getting symfony-cmf/Testing#168 ready