chore(DRAFT): use acorn
, estree
and esrap
#100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #94
Closes #44
Benefits
svelte
ecosystemesrap
Downsides
esrap
Depends on Rich-Harris/esrap#13. Currently published as
esrap-typescript-temp
for ease of use for testing. Otherwise, this would require usingpnpm link
locally with the branch mentioned before.If we want to proceed with this (which i think we should), this needs to be done
packages/ast-tooling/ts-estree.ts
seperately so that it can also be used insideesrap
. Later they should probably live insideacorn-typescript
once we fork itesrap
understand what aTSModuleDeclaration
is and how to print itesrap
according to the types above. This will probably also require way more types in this new packageesrap
and publish it