Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use single quotes in new script files #96

Merged
merged 9 commits into from
Oct 14, 2024

Conversation

manuel3108
Copy link
Member

Closes #44

Copy link

changeset-bot bot commented Oct 12, 2024

🦋 Changeset detected

Latest commit: f32cb21

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Oct 12, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/sveltejs/cli/sv@96

commit: f32cb21

Comment on lines 74 to 75
useTabs: false,
tabWidth: 4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll want to default to using tabs instead of spaces

Suggested change
useTabs: false,
tabWidth: 4
useTabs: true,
tabWidth: undefined

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im starting to really despise recast, lol. it's still using 2 spaces

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sv create foo > select tailwind > look at tailwind.config.ts

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hurray! this is awesome!

@AdrianGonz97 AdrianGonz97 changed the title fix: intentation on new script files fix: indentation on new script files Oct 12, 2024
@manuel3108 manuel3108 changed the title fix: indentation on new script files draft: fix: indentation on new script files Oct 13, 2024
@manuel3108
Copy link
Member Author

At this point, this is only a draft. Hopefully we can close this PR entirely later today.

@manuel3108
Copy link
Member Author

Superseded by #100

@manuel3108 manuel3108 closed this Oct 13, 2024
@manuel3108 manuel3108 deleted the fix/intentation-on-new-script-files branch October 13, 2024 14:11
@benmccann
Copy link
Member

I think this would be nice to merge still so that users have a better experience until #100 lands. Unless we think we can land that one before launch. But that could be a lot to do and just add more pressure to get things done

@manuel3108 manuel3108 restored the fix/intentation-on-new-script-files branch October 13, 2024 14:25
@manuel3108 manuel3108 reopened this Oct 13, 2024
@manuel3108
Copy link
Member Author

Good point, although im not sure if this is a major improvement, but it should still be an improvement.

@manuel3108
Copy link
Member Author

Did you guys had a chance to test that? Do you think it's generally better or worse? Is there anything that prevents us from merging?

@AdrianGonz97 AdrianGonz97 changed the title draft: fix: indentation on new script files fix: use single quotes in new script files Oct 14, 2024
Copy link
Member

@AdrianGonz97 AdrianGonz97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the title since the "indentation" bit isn't exactly true because of recast. should be good to go!

@manuel3108 manuel3108 merged commit c1618bc into main Oct 14, 2024
5 checks passed
@manuel3108 manuel3108 deleted the fix/intentation-on-new-script-files branch October 14, 2024 16:43
@github-actions github-actions bot mentioned this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File created with mix of single and double quotes
3 participants