Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auth_query support #132

Merged
merged 5 commits into from
Jul 19, 2023
Merged

feat: auth_query support #132

merged 5 commits into from
Jul 19, 2023

Conversation

abc3
Copy link
Member

@abc3 abc3 commented Jul 16, 2023

This PR adds the implementation of auth_query support, which allows the system to authenticate user credentials dynamically by retrieving SCRAM secrets from pg_authid

issue: #120

@abc3 abc3 linked an issue Jul 17, 2023 that may be closed by this pull request
9 tasks
@abc3 abc3 changed the title feat: start pools even if user isn't in user table feat: auth_query support Jul 17, 2023
@abc3 abc3 requested review from chasers and a team July 17, 2023 19:30
lib/supavisor/helpers.ex Outdated Show resolved Hide resolved
lib/supavisor/helpers.ex Outdated Show resolved Hide resolved
lib/supavisor/helpers.ex Outdated Show resolved Hide resolved
lib/supavisor.ex Outdated Show resolved Hide resolved
@abc3
Copy link
Member Author

abc3 commented Jul 18, 2023

@josevalim, could you please check updates based on your comments when you have a chance?

@abc3 abc3 requested a review from josevalim July 18, 2023 10:22
Copy link
Contributor

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ship it!

@delgado3d delgado3d merged commit 360b5f5 into main Jul 19, 2023
2 checks passed
@abc3 abc3 deleted the feat/auth_query branch July 19, 2023 21:06
@Neustradamus
Copy link

@abc3: Good job!

Linked to:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Start pools even if user isn't in user table
4 participants