Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start pools even if user isn't in user table #120

Closed
6 of 9 tasks
chasers opened this issue Jul 3, 2023 · 1 comment · Fixed by #132
Closed
6 of 9 tasks

Start pools even if user isn't in user table #120

chasers opened this issue Jul 3, 2023 · 1 comment · Fixed by #132
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@chasers
Copy link
Contributor

chasers commented Jul 3, 2023

  • Use some "default user pool config" with a pool_size
  • pool_type should be based on port maybe - 5432 = session and 6543 = transaction
  • Flag on tenant record for require_user and if require_user is false we allow user creds to pull from connection string or other method
  • require_user field default false
  • Authentication of user to tenant database will happen on pool start and error to client if auth fails
  • tenant username and pass stored in Cachex
  • Docs - overview of this behavior
  • Docs - tell people what happens if they change username/pass in tenant db
  • Docs - example auth user query
@chasers chasers added the enhancement New feature or request label Jul 3, 2023
@darora
Copy link

darora commented Jul 3, 2023

I think you'll also require some info (e.g. creds) to verify the client creds?

This is how we configure pgbouncer: https://github.com/supabase/postgres/blob/develop/ansible/files/pgbouncer_config/pgbouncer.ini.j2#L115-L124

@abc3 abc3 self-assigned this Jul 5, 2023
@chasers chasers added this to the v0.2.0 milestone Jul 13, 2023
@abc3 abc3 linked a pull request Jul 17, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants