Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no-wrap option #153

Merged
merged 1 commit into from
Jan 9, 2024
Merged

fix: no-wrap option #153

merged 1 commit into from
Jan 9, 2024

Conversation

alanshaw
Copy link
Member

@alanshaw alanshaw commented Jan 9, 2024

Accessing via 'no-wrap' does not work - it is ALWAYS false for some reason.

  • If --no-wrap is passed, options.wrap will be false, otherwise undefined
  • If --wrap is passed, options.wrap will be true

Also a tiny fix to ensure our store percentage cannot go over 100% (it can do because of CAR overhead).

reoslves #148

Copy link
Contributor

@olizilla olizilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no --no-wrap is go.

@alanshaw alanshaw merged commit 9ae49e9 into main Jan 9, 2024
1 check passed
@alanshaw alanshaw deleted the fix/no-wrap branch January 9, 2024 16:21
alanshaw pushed a commit that referenced this pull request Jan 9, 2024
🤖 I have created a release *beep* *boop*
---


##
[7.0.4](v7.0.3...v7.0.4)
(2024-01-09)


### Bug Fixes

* no-wrap option
([#153](#153))
([9ae49e9](9ae49e9))
* update notification includes -g flag for cli
([#150](#150))
([370bfc6](370bfc6))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants