fix: make w3 up --no-wrap work as advertised.
#160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix and test handling of wrap option to w3 up. | flag | result | |--------------|-------------| | undefined | wrap: true | | --wrap | wrap: true | | --wrap true | wrap: true | | --wrap=true | wrap: true | | --wrap false | wrap: false | | --wrap=false | wrap: false | | --no-wrap | wrap: false | License: MIT Signed-off-by: Oli Evans <[email protected]>
|
not sure what happend in #153 but I promise this makes it work more intuitively. |
olizilla
commented
Jan 17, 2024
alanshaw
approved these changes
Jan 17, 2024
olizilla
commented
Jan 17, 2024
License: MIT Signed-off-by: Oli Evans <[email protected]>
olizilla
changed the title
w3 up --no-wrap work as advertised.
passing a default forces it to be parsed as a boolean, which makes hidden=true work as expected. License: MIT Signed-off-by: Oli Evans <[email protected]>
olizilla
pushed a commit
that referenced
this pull request
Jan 17, 2024
🤖 I have created a release *beep* *boop* --- ## [7.2.1](v7.2.0...v7.2.1) (2024-01-17) ### Bug Fixes * make `w3 up --no-wrap` work as advertised. ([#160](#160)) ([426faad](426faad)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix and test handling of
--wrapoption tow3 upAlso normalises the behaviour of other boolean flags to
w3 upso we can set them likew3 up --hidden=${{input.hidden}}in scripts, where it would be fiddly to optionally include a flag. see: https://github.com/web3-storage/add-to-web3/pull/89/files#diff-1243c5424efaaa19bd8e813c5e6f6da46316e63761421b3e5f5c8ced9a36e6b6R51License: MIT