Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve mass nav header rendering to obey ds customization on tabs #2562

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

xzhou82
Copy link
Collaborator

@xzhou82 xzhou82 commented Jan 4, 2025

Description

closes #2561
briefly tested to work with termdbtest, profile, and pnet. CI passed. please test more

all pass: http://localhost:3000/testrun.html?dir=mass&name=nav.integration

Checklist

Check each task that has been performed or verified to be not applicable.

  • Tests: added and/or passed unit and integration tests, or N/A
  • Todos: commented or documented, or N/A
  • Notable Changes: updated release.txt, prefixed a commit message with "fix:" or "feat:", added to an internal tracking document, or N/A

@karishma-gangwani
Copy link
Contributor

all-pharmacotyping ds shows error in nav.js. can you check @xzhou82

error: TypeError: Cannot add property mid, object is not extensible
    at self.initUI (nav.js:291:33)
    at TdbNav.init (nav.js:62:9)
    at index.js:138:50
    at MassApp.init (app.js:117:33)
    at async Module.<anonymous> (index.js:139:10)

@xzhou82
Copy link
Collaborator Author

xzhou82 commented Jan 6, 2025

thanks @karishma-gangwani the bug is fixed, please test again

Copy link
Contributor

@karishma-gangwani karishma-gangwani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works now. thanks @xzhou82

@xzhou82 xzhou82 merged commit a419ba8 into master Jan 6, 2025
3 checks passed
@xzhou82 xzhou82 deleted the issue.2561 branch January 6, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mass nav logic clean up
2 participants