Skip to content

Commit

Permalink
do not directly modify state obj
Browse files Browse the repository at this point in the history
  • Loading branch information
xzhou82 committed Jan 6, 2025
1 parent 4719b88 commit a419ba8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion client/mass/nav.js
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ function setRenderers(self) {
self.tabs.push(aboutTab)
// about tab contents are conditionally determined by 1) override 2) ds using or not using cohort.
// furbish an override object with default properties based on conditions if those properties are missing
const override = massNav.tabs?.about || {}
const override = Object.assign({}, massNav.tabs?.about)
if (appState.termdbConfig?.selectCohort) {
// ds has cohort selection and no customization to about tab
if (!override.top) override.top = 'COHORT'
Expand Down

0 comments on commit a419ba8

Please sign in to comment.