Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gemspec to be compatible with Rails 8 #726

Merged
merged 3 commits into from
Dec 15, 2024
Merged

Update gemspec to be compatible with Rails 8 #726

merged 3 commits into from
Dec 15, 2024
+13 −13

Conversation

sara-g
Copy link
Contributor

@sara-g sara-g commented Nov 23, 2024

Installing stimulus reflex on Rails 8.0 was failing, this change will get it to install.

@netlify Netlify
Copy link

netlify bot commented Nov 23, 2024 •
edited
Loading

✅ Deploy Preview for stimulusreflex ready!

Name Link
🔨 Latest commit 4ce800a
🔍 Latest deploy log https://app.netlify.com/sites/stimulusreflex/deploys/675e8fa6d7e36d0008b009fb
😎 Deploy Preview https://deploy-preview-726--stimulusreflex.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

marcoroth
marcoroth reviewed Dec 5, 2024
View reviewed changes
Copy link
Member

@marcoroth marcoroth left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sara-g, thanks for this!

Would you mind committing the Gemfile.lock too, thank you!

@marcoroth marcoroth changed the title work on rails 8 and future versions Update gemspec to be compatible with Rails 8 Dec 15, 2024
marcoroth
marcoroth approved these changes Dec 15, 2024
View reviewed changes
Copy link
Member

@marcoroth marcoroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sara-g

@marcoroth marcoroth merged commit 39388ab into stimulusreflex:main Dec 15, 2024
5 checks passed
@marcoroth marcoroth mentioned this pull request Dec 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoroth marcoroth marcoroth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sara-g @marcoroth