Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compability with Ruby on Rails 8 #722

Closed
rodrigotoledo opened this issue Oct 8, 2024 · 6 comments
Closed

Compability with Ruby on Rails 8 #722

rodrigotoledo opened this issue Oct 8, 2024 · 6 comments

Comments

@rodrigotoledo
Copy link

Bug Report

Maybe this isn't a bug, but I was trying to demonstrate how this gem works to my friend. My project is using Ruby on Rails 8, and nothing happens when I try to show it. Maybe it's a bug with the new version. Shall we take a look?

Describe the bug

I install the gem, set up, then create the reflex class and add a method to render a partial.

To Reproduce

When I create the button with an action calling my reflex class and method, nothing happens.

Expected behavior

In Rails version 7, the reflex class is called and the morph method is invoked.

Versions

StimulusReflex

  • Gem: 3.5
@JuanMiguelGM
Copy link

Hi, are there any intentions to support Rails 8?

@marcoroth
Copy link
Member

Yes, going to look into this.

@pacso
Copy link

pacso commented Nov 26, 2024

The lack of support for Rails 8, and the extremely slow response here has been enough for us to make the jump away from Stimulus Reflex.

Thank you for all of your efforts - it was a novel approach which I'm sure influenced the development of the various Hotwire Turbo packages.

@marcoroth
Copy link
Member

Hey @pacso, thanks for your feedback!

I’m sorry to hear that the lack of Rails 8 support and the response time here have caused frustration.

StimulusReflex has been an exploration of what’s possible in reactive Rails applications, and while we’ve shifted much of our focus toward improving Hotwire itself and contributing upstream to make the broader ecosystem stronger, we recognize that this has impacted our ability to maintain the project at the level you and others might expect.

Turbo really leveled up in the meantime, especially now that we finally also have basic support for morphing in Turbo 8. I think it's fair to say that relying on just Turbo might be enough for most applications today.

That said, contributions to StimulusReflex are always welcome, and if there’s interest in helping advance support for Rails 8 or other areas please let me know, I'd love to help.

Thank you again for using StimulusReflex in the first place and for recognizing the effort that went into it. Let us know if we can assist you in any way!

Best,
Marco

@sara-g
Copy link
Contributor

sara-g commented Nov 29, 2024

I got this to work in Rails 8, I put in a PR.

@marcoroth
Copy link
Member

marcoroth commented Dec 15, 2024

Just merged #726 and going to follow up with a v3.5.3 release shortly! 🙌

Please feel free to re-open if you see any other issue with Rails 8, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants