Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(BC)_: Fix personal_sign RPC event processing #6090

Open
wants to merge 1 commit into
base: fix/BC_fix_event
Choose a base branch
from
+6 −12
Open

fix(BC)_: Fix personal_sign RPC event processing #6090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions services/connector/commands/personal_sign.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,18 +29,17 @@ func (r *RPCRequest) getPersonalSignParams() (*PersonalSignParams, error) {
return nil, ErrEmptyRPCParams
}

paramMap, ok := r.Params[0].(map[string]interface{})
if !ok {
if len(r.Params) < 2 {
return nil, ErrInvalidParamsStructure
}

// Extract the Challenge and Address fields from paramMap
challenge, ok := paramMap["challenge"].(string)
// Extract the Challenge and Address fields from paramsArray
challenge, ok := r.Params[0].(string)
if !ok {
return nil, fmt.Errorf("missing or invalid 'challenge' field")
}

address, ok := paramMap["address"].(string)
address, ok := r.Params[1].(string)
if !ok {
return nil, fmt.Errorf("missing or invalid 'address' field")
}
Expand Down
7 changes: 1 addition & 6 deletions services/connector/commands/personal_sign_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,7 @@ import (
)

func preparePersonalSignRequest(dApp signal.ConnectorDApp, challenge, address string) (RPCRequest, error) {
params := map[string]interface{}{
"challenge": challenge,
"address": address,
}

return ConstructRPCRequest("personal_sign", []interface{}{params}, &dApp)
return ConstructRPCRequest("personal_sign", []interface{}{challenge, address}, &dApp)
}

func TestFailToPersonalSignWithMissingDAppFields(t *testing.T) {
Expand Down
2 changes: 1 addition & 1 deletion services/connector/connector_flows_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ func TestRequestAccountsSwitchChainAndSendTransactionFlow(t *testing.T) {
assert.Equal(t, expectedHash.Hex(), response)

// Personal sign
request = "{\"method\": \"personal_sign\", \"params\":[{\"challenge\": \"0x506c65617365207369676e2074686973206d65737361676520746f20636f6e6669726d20796f7572206964656e746974792e\",\"address\":\"0x4B0897b0513FdBeEc7C469D9aF4fA6C0752aBea7\"}], \"url\": \"http://testDAppURL123\", \"name\": \"testDAppName\", \"iconUrl\": \"http://testDAppIconUrl\" }"
request = "{\"method\": \"personal_sign\", \"params\":[\"0x506c65617365207369676e2074686973206d65737361676520746f20636f6e6669726d20796f7572206964656e746974792e\",\"0x4B0897b0513FdBeEc7C469D9aF4fA6C0752aBea7\"], \"url\": \"http://testDAppURL123\", \"name\": \"testDAppName\", \"iconUrl\": \"http://testDAppIconUrl\" }"
response, err = state.api.CallRPC(state.ctx, request)
assert.NoError(t, err)
assert.Equal(t, expectedSignature, response)
Expand Down