fix(BC)_: Fix personal_sign RPC event processing #6090
+6
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The personal_sign RPC event parsing. Changed `params` from object array to string array.
alexjba
requested review from
alaibe,
dlipicar,
Cuteivist,
Khushboo-dev-cpp and
saledjenic
Jenkins Builds
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## fix/BC_fix_event #6090 +/- ##
====================================================
+ Coverage 60.79% 60.88% +0.08%
====================================================
Files 811 811
Lines 108916 108915 -1
====================================================
+ Hits 66220 66308 +88
+ Misses 34919 34844 -75
+ Partials 7777 7763 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the personal_sign RPC event parsing. Changed
paramsfrom object array to string array.https://docs.metamask.io/wallet/reference/json-rpc-methods/personal_sign/
Needed for status-im/status-desktop#16015