fix(telemetry)_: fix flaky cache test #5885
Open
+20
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (5)
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #5885 +/- ##
==========================================
Coverage ? 46.07%
==========================================
Files ? 888
Lines ? 157372
Branches ? 0
==========================================
Hits ? 72507
Misses ? 76548
Partials ? 8317
Flags with carried forward coverage won't be shown. Click here to find out more. |
adklempner
force-pushed
the
fix/telemetry-cache-test
branch
from
632d7e9
to
327be21
Compare
adklempner
force-pushed
the
fix/telemetry-cache-test
branch
from
327be21
to
14f75f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix flaky test for telemetry cache by removing use of
time.SleepTelemetry behavior is dependent on timing, which can be hard to reproduce across all testing environments. Instead of running the telemetry client's main go routines via
Start()and usingtime.Sleepto trigger its timer, invoke the functionality being tested directly.