fix(telemetry)_: fix flaky cache test #5885
Open
+20
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix flaky test for telemetry cache by removing use of
time.Sleep
Telemetry behavior is dependent on timing, which can be hard to reproduce across all testing environments. Instead of running the telemetry client's main go routines via
Start()
and usingtime.Sleep
to trigger its timer, invoke the functionality being tested directly.