You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Tests need to be deterministic. Currently, tests of the telemetry client rely on use of time.Sleep to trigger the behavior.
Implementation
Replace use of time.Sleep with direct invocation of functionality being tested (e.g. #5885 )
Acceptance Criteria
No instances of time.Sleep in telemetry/client_test.go
Notes
Likely means using client.Start() in tests is a no-go. May be worth refactoring some of the logic within the go-routines that it starts into functions.
Future Steps
Avoid time.Sleep in new tests moving forward
The text was updated successfully, but these errors were encountered:
Problem
Tests need to be deterministic. Currently, tests of the telemetry client rely on use of
time.Sleep
to trigger the behavior.Implementation
Replace use of
time.Sleep
with direct invocation of functionality being tested (e.g. #5885 )Acceptance Criteria
No instances of
time.Sleep
intelemetry/client_test.go
Notes
Likely means using
client.Start()
in tests is a no-go. May be worth refactoring some of the logic within the go-routines that it starts into functions.Future Steps
Avoid
time.Sleep
in new tests moving forwardThe text was updated successfully, but these errors were encountered: