-
-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow building stash without CGo (using modernc.org/sqlite as option) #4106
Open
its-josh4
wants to merge
10
commits into
stashapp:develop
Choose a base branch
from
its-josh4:cgo-off
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
its-josh4
added a commit
to its-josh4/stash
that referenced
this pull request
Sep 11, 2023
Includes some dependencies that were upgraded in stashapp#4106 as well as a few more dependencies. Notably, removes deprecated dependencies such as `github.com/go-chi/chi` (replaced with `/v5`), and upgrades some deps that had CVEs.
its-josh4
added a commit
to its-josh4/stash
that referenced
this pull request
Sep 11, 2023
Includes some dependencies that were upgraded in stashapp#4106 as well as a few more dependencies. Some deps that have been upgraded had CVEs. Notably, upgrades deprecated dependencies such as: - `github.com/go-chi/chi` (replaced with `/v5`) - `github.com/gofrs/uuid` (replaced with `/v5`) - `github.com/hashicorp/golang-lru` (replaced with `/v2` which uses generics)
its-josh4
changed the title
WIP: Allow building stash without CGo (using modernc.org/sqlite as option)
Allow building stash without CGo (using modernc.org/sqlite as option)
Oct 22, 2023
its-josh4
added a commit
to its-josh4/stash
that referenced
this pull request
Oct 22, 2023
WithoutPants
pushed a commit
that referenced
this pull request
Oct 22, 2023
WithoutPants
pushed a commit
that referenced
this pull request
Oct 26, 2023
* Update a number of dependencies (incl. CVE fixes) Includes some dependencies that were upgraded in #4106 as well as a few more dependencies. Some deps that have been upgraded had CVEs. Notably, upgrades deprecated dependencies such as: - `github.com/go-chi/chi` (replaced with `/v5`) - `github.com/gofrs/uuid` (replaced with `/v5`) - `github.com/hashicorp/golang-lru` (replaced with `/v2` which uses generics) * Upgraded a few more deps * lint * reverted yaml library to v2 * remove unnecessary mod replace * Update chromedp Fixes #3733
halkeye
pushed a commit
to halkeye/stash
that referenced
this pull request
Sep 1, 2024
halkeye
pushed a commit
to halkeye/stash
that referenced
this pull request
Sep 1, 2024
* Update a number of dependencies (incl. CVE fixes) Includes some dependencies that were upgraded in stashapp#4106 as well as a few more dependencies. Some deps that have been upgraded had CVEs. Notably, upgrades deprecated dependencies such as: - `github.com/go-chi/chi` (replaced with `/v5`) - `github.com/gofrs/uuid` (replaced with `/v5`) - `github.com/hashicorp/golang-lru` (replaced with `/v2` which uses generics) * Upgraded a few more deps * lint * reverted yaml library to v2 * remove unnecessary mod replace * Update chromedp Fixes stashapp#3733
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4103
CGO_ENABLED=0
beforemake
. e.g.CGO_ENABLED=0 make build
modernc.org/sqlite
as a SQLite driver when CGo is not available. If stash is compiled with CGo available, the existing sqlite driver is used.