-
-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update a number of dependencies (incl. CVE fixes) #4107
Conversation
Includes some dependencies that were upgraded in stashapp#4106 as well as a few more dependencies. Some deps that have been upgraded had CVEs. Notably, upgrades deprecated dependencies such as: - `github.com/go-chi/chi` (replaced with `/v5`) - `github.com/gofrs/uuid` (replaced with `/v5`) - `github.com/hashicorp/golang-lru` (replaced with `/v2` which uses generics)
8ed2f61
to
45775f7
Compare
I'm running into a few issues with the If you clone the CommunityScrapers repo and set your scraper path to that, you'll get a "did not find expected key" error for both the There are a couple issues on the https://github.com/go-yaml/yaml repo relating to newline issues, and many of them are quite old. I have a feeling we're going to have to fix the bug ourselves, or find a non-broken version to use. |
I can downgrade the YAML library |
@its-josh4 I think that's the best option for now yes. v2.4.0 seems to be the latest version that doesn't have this issue, and it is the version we were on previously as well. |
@its-josh4 I believe the last line in |
@DingDongSoLong4 updated as you requested. Reverted the YAML library to v2, and removed the unnecessary replacement in go.mod (also fixed merge conflicts) |
@its-josh4 If you wouldn't mind, can you also upgrade |
Done. Maybe this PR could be merged and other deps can be updated separately? |
* Update a number of dependencies (incl. CVE fixes) Includes some dependencies that were upgraded in stashapp#4106 as well as a few more dependencies. Some deps that have been upgraded had CVEs. Notably, upgrades deprecated dependencies such as: - `github.com/go-chi/chi` (replaced with `/v5`) - `github.com/gofrs/uuid` (replaced with `/v5`) - `github.com/hashicorp/golang-lru` (replaced with `/v2` which uses generics) * Upgraded a few more deps * lint * reverted yaml library to v2 * remove unnecessary mod replace * Update chromedp Fixes stashapp#3733
Includes some dependencies that were upgraded in #4106 as well as a few more dependencies.
Some deps that have been upgraded had CVEs.
Notably, upgrades deprecated dependencies such as:
github.com/go-chi/chi
(replaced with/v5
)github.com/gofrs/uuid
(replaced with/v5
)github.com/hashicorp/golang-lru
(replaced with/v2
which uses generics)Fixes #3733