Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix keyboard input: fix focus onMenuClose and fix some key bindings #1042

Merged
merged 2 commits into from
Feb 25, 2024
Merged

Fix keyboard input: fix focus onMenuClose and fix some key bindings #1042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3173628
Fix keyboard bindings of PianoRollWindow to match the comments
liuycsd Feb 16, 2024
1458949
Make MainWindow and PianoRollWindow focusable to fix focusing OnMenuC…
liuycsd Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions OpenUtau/Views/MainWindow.axaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
Icon="/Assets/open-utau.ico"
Title="{Binding Title}" MinWidth="300" MinHeight="200"
KeyDown="OnKeyDown" PointerPressed="OnPointerPressed" Closing="WindowClosing"
Focusable="True"
TransparencyLevelHint="None"
ExtendClientAreaToDecorationsHint="{Binding ExtendToFrame}">
<Window.Styles>
Expand Down
1 change: 1 addition & 0 deletions OpenUtau/Views/PianoRollWindow.axaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
x:Class="OpenUtau.App.Views.PianoRollWindow"
Icon="/Assets/open-utau.ico"
Title="{Binding NotesViewModel.WindowTitle}" MinWidth="300" MinHeight="200" KeyDown="OnKeyDown" Closing="WindowClosing"
Focusable="True"
TransparencyLevelHint="None"
ExtendClientAreaToDecorationsHint="{Binding ExtendToFrame}" Deactivated="WindowDeactivated">
<Window.Styles>
Expand Down
4 changes: 2 additions & 2 deletions OpenUtau/Views/PianoRollWindow.axaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1321,7 +1321,7 @@ bool OnKeyExtendedHandler(KeyEventArgs args) {
}
// to view end
if (isShift) {
playVm.MovePlayPos(notesVm.Part.position + (int)(notesVm.TickOffset));
playVm.MovePlayPos(notesVm.Part.position + (int)(notesVm.TickOffset + notesVm.Bounds.Width / notesVm.TickWidth));
return true;
}
break;
Expand Down Expand Up @@ -1349,7 +1349,7 @@ bool OnKeyExtendedHandler(KeyEventArgs args) {
}
// select none
if (isCtrl) {
notesVm.SelectAllNotes();
notesVm.DeselectNotes();
return true;
}
break;
Expand Down