Fix keyboard input: fix focus onMenuClose and fix some key bindings #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some keyboard input issues:
Fix some key bindings that do not match the comments:
Ctrl+DShift+]Try to fix a focus issue when the user leave the Menu but the focus could still be on the MenuItem, making Home/End and other navigation keys do not work as expected (they still navigate in the menu region and can not move the playback or note position).
This issue could happen if the menu is closed when the mouse pointer is on the tool bar or if the user use Alt/Esc keys to navigate the menu.
I'm not sure whether not not it is a correct way to fix this by explicitly setting the main window focusable.