Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Construction of OIDC endpoint when rootPath has a trailing slash #656

Merged
merged 6 commits into from
Nov 25, 2024
Merged

fix: Construction of OIDC endpoint when rootPath has a trailing slash #656

merged 6 commits into from
Nov 25, 2024
+501 −172

Conversation

labrenbe
Copy link
Member

@labrenbe labrenbe commented Nov 22, 2024 •
edited
Loading

Description

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Beta Give feedback

Reviewer
Beta Give feedback

Acceptance
Beta Give feedback

labrenbe
labrenbe commented Nov 22, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@NickLarsenNZ NickLarsenNZ mentioned this pull request Nov 22, 2024
Draft
@sbernauer sbernauer self-requested a review November 22, 2024 14:33
@sbernauer sbernauer mentioned this pull request Nov 22, 2024
Merged
5 tasks
@labrenbe labrenbe changed the title fix: let operator-rs generate oidc discovery url fix: Calculation of OIDC endpoint when rootPath has a trailing slash Nov 22, 2024
@labrenbe labrenbe marked this pull request as ready for review November 22, 2024 15:56
@siegfriedweber siegfriedweber mentioned this pull request Nov 23, 2024
Merged
@sbernauer
Copy link
Member

Started https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/druid-operator-it-custom/22/

@labrenbe labrenbe changed the title fix: Calculation of OIDC endpoint when rootPath has a trailing slash fix: Construction of OIDC endpoint when rootPath has a trailing slash Nov 25, 2024
sbernauer
sbernauer reviewed Nov 25, 2024
View reviewed changes
Cargo.toml Show resolved Hide resolved
sbernauer
sbernauer requested changes Nov 25, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

rust/operator-binary/src/authentication/mod.rs Outdated Show resolved Hide resolved
@labrenbe labrenbe added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit 4acfec9 Nov 25, 2024
16 of 17 checks passed
@labrenbe labrenbe deleted the fix/oidc-well-known-url branch November 25, 2024 10:38
@siegfriedweber siegfriedweber mentioned this pull request Nov 25, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees

@labrenbe labrenbe

Labels
release/2024-11 type/bug
Projects
Stackable Engineering
Status: Development: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@labrenbe @sbernauer