-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch op-rs version to use one that fixes SUP-148. #657
Merged
siegfriedweber
merged 9 commits into
main
from
fix/SUP-148_rebased_on_fix/oidc-well-known-url
Nov 25, 2024
Merged
Patch op-rs version to use one that fixes SUP-148. #657
siegfriedweber
merged 9 commits into
main
from
fix/SUP-148_rebased_on_fix/oidc-well-known-url
Nov 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some minor changes needed to remove dependency on now private fn in op-rs.
siegfriedweber
changed the title
Fix/sup 148 rebased on fix/OIDC well known url
fix/SUP-148_rebased_on_fix/oidc-well-known-url
Nov 23, 2024
siegfriedweber
changed the title
fix/SUP-148_rebased_on_fix/oidc-well-known-url
fix/SUP-148 rebased on fix/oidc-well-known-url
Nov 23, 2024
siegfriedweber
changed the title
fix/SUP-148 rebased on fix/oidc-well-known-url
Patch op-rs version to use one that fixes SUP-148.
Nov 23, 2024
This was referenced Nov 23, 2024
maltesander
previously approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor thing, LGTM! otherwise
maltesander
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
siegfriedweber
deleted the
fix/SUP-148_rebased_on_fix/oidc-well-known-url
branch
November 25, 2024 14:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use distinct ServiceAccounts for the Stacklets, so that multiple Stacklets can be deployed in one namespace. Existing Stacklets will use the newly created ServiceAccounts after restart.
Definition of Done Checklist
Author
Reviewer
Acceptance