Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch op-rs version to use one that fixes SUP-148. #657

Merged
merged 9 commits into from
Nov 25, 2024

Conversation

siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented Nov 23, 2024

Description

Use distinct ServiceAccounts for the Stacklets, so that multiple Stacklets can be deployed in one namespace. Existing Stacklets will use the newly created ServiceAccounts after restart.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

Acceptance

@siegfriedweber siegfriedweber self-assigned this Nov 23, 2024
@siegfriedweber siegfriedweber changed the title Fix/sup 148 rebased on fix/OIDC well known url fix/SUP-148_rebased_on_fix/oidc-well-known-url Nov 23, 2024
@siegfriedweber siegfriedweber changed the title fix/SUP-148_rebased_on_fix/oidc-well-known-url fix/SUP-148 rebased on fix/oidc-well-known-url Nov 23, 2024
@siegfriedweber siegfriedweber changed the title fix/SUP-148 rebased on fix/oidc-well-known-url Patch op-rs version to use one that fixes SUP-148. Nov 23, 2024
maltesander
maltesander previously approved these changes Nov 25, 2024
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing, LGTM! otherwise

rust/operator-binary/src/druid_controller.rs Outdated Show resolved Hide resolved
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@siegfriedweber siegfriedweber added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit acaef46 Nov 25, 2024
16 of 17 checks passed
@siegfriedweber siegfriedweber deleted the fix/SUP-148_rebased_on_fix/oidc-well-known-url branch November 25, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants