Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go version to 1.21 (Revenge) #105

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Update go version to 1.21 (Revenge) #105

merged 1 commit into from
Mar 1, 2024
+26 −28

Conversation

gold-kou
Copy link
Contributor

@gold-kou gold-kou commented Feb 8, 2024 •
edited
Loading

Description

Reverted before.
#104

Fixed the problem.

What I did:

  • Updated go in ci
  • Updated go in Dockerfile
  • Fixed to use go install in Makefile
  • Fixed docs
  • Fixed go.mod (this is not required)
  • Executed go mod tidy and go.sum is updated

Checklist

Please check if applicable

  • Tests have been added (if applicable, ie. when operator codes are added or modified)
  • Relevant docs have been added or modified (if applicable, ie. when new features are added or current features are modified)

Relevant issue #87

@gold-kou gold-kou self-assigned this Feb 8, 2024
@gold-kou gold-kou requested a review from a team February 8, 2024 02:57
kane8n
kane8n approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@kane8n kane8n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

sejima1105
sejima1105 approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@sejima1105 sejima1105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gold-kou gold-kou merged commit b4d435a into st-tech:main Mar 1, 2024
3 checks passed
@gold-kou gold-kou changed the title Update go version to 1.21 Update go version to 1.21 (Revenge) Mar 1, 2024
This was referenced Mar 1, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sejima1105 sejima1105 sejima1105 approved these changes

@kane8n kane8n kane8n approved these changes

Assignees

@gold-kou gold-kou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gold-kou @kane8n @sejima1105