Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go version to 1.21 #108

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Conversation

gold-kou
Copy link
Contributor

@gold-kou gold-kou commented Mar 1, 2024

Description

The previous PR for updating go was reverted since the ci failed.
#107

This PR is a revenge of it.
I added to fix the version of sigs.k8s.io/kustomize/kustomize from [email protected] to [email protected] which is the latest.
I assume that the old kustomize used exclude directive is a reason.
https://github.com/kubernetes-sigs/kustomize/blob/kustomize/v3.8.7/kustomize/go.mod

Confirmed the make command works correctly.

% make manifests-release
/Users/koki.hatano/github/gold-kou/gatling-operator/bin/controller-gen "crd:trivialVersions=true,preserveUnknownFields=false" rbac:roleName=manager-role webhook paths="./..." output:crd:artifacts:config=config/crd/bases
cd config/manager && /Users/koki.hatano/github/gold-kou/gatling-operator/bin/kustomize edit set image controller=gatling-operator:20240301-143405
/Users/koki.hatano/github/gold-kou/gatling-operator/bin/kustomize build config/default > gatling-operator.yaml

The other changes are same with #105 .

Checklist

Please check if applicable

  • Tests have been added (if applicable, ie. when operator codes are added or modified)
  • Relevant docs have been added or modified (if applicable, ie. when new features are added or current features are modified)

Relevant issue #

@gold-kou gold-kou self-assigned this Mar 1, 2024
@gold-kou gold-kou requested a review from a team March 1, 2024 05:50
Copy link
Contributor

@sejima1105 sejima1105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gold-kou gold-kou merged commit bed9de0 into st-tech:main Mar 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants