Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translate motd when join game #794

Merged
merged 14 commits into from
Dec 3, 2023
Merged

translate motd when join game #794

merged 14 commits into from
Dec 3, 2023

Conversation

BR54FF
Copy link

@BR54FF BR54FF commented Nov 30, 2023

Что этот PR делает

Перевод motd при заходе на профу

Почему это хорошо для игры

перевод

Изображения изменений

image
image

Тестирование

локалка

Changelog

🆑
tweak: Перевод приветственных сообщений при заходе на роль
/:cl:

@github-actions github-actions bot added the :finnadie: НЕ МОДУЛЬНО Па-ху-ю. label Nov 30, 2023
@BR54FF
дефинесы
a310dfc 
гагага
@BR54FF
nado
a11121c 
biba
@BR54FF
Revert "дефинесы"
3cafd3a 
This reverts commit a310dfc.
@BR54FF BR54FF marked this pull request as ready for review November 30, 2023 14:12
@dj-34 dj-34 added the 📝 Перевод Приятно когда всё на родном языке. label Nov 30, 2023
dj-34
dj-34 reviewed Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@dj-34 dj-34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Почему у тебя разнобой в СРП? Где-то с маленьких начинается, где-то с больших. Также и с КЗ

code/game/jobs/job/supervisor.dm Outdated Show resolved Hide resolved
Legendaxe
Legendaxe requested changes Dec 1, 2023
View reviewed changes
Copy link

@Legendaxe Legendaxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ожидаем фикса ревью диджея

@BR54FF
Copy link
Author

BR54FF commented Dec 2, 2023

наконец выдалось время, исправил

AyIong
AyIong approved these changes Dec 2, 2023
View reviewed changes
Copy link
Collaborator

@AyIong AyIong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Красиво

dj-34
dj-34 requested changes Dec 2, 2023
View reviewed changes
code/game/jobs/job/support.dm Outdated Show resolved Hide resolved
code/game/jobs/job/supervisor.dm Outdated Show resolved Hide resolved
code/controllers/subsystem/SSjobs.dm Outdated Show resolved Hide resolved
dj-34
dj-34 requested changes Dec 2, 2023
View reviewed changes
code/controllers/subsystem/SSjobs.dm Outdated Show resolved Hide resolved
code/controllers/subsystem/SSjobs.dm Outdated Show resolved Hide resolved
code/game/jobs/job/supervisor.dm Outdated Show resolved Hide resolved
code/game/jobs/job/supervisor.dm Outdated Show resolved Hide resolved
code/game/jobs/job/supervisor.dm Outdated Show resolved Hide resolved
code/game/jobs/job/supervisor.dm Outdated Show resolved Hide resolved
@dj-34
Copy link
Collaborator

dj-34 commented Dec 2, 2023

Кстати чтобы не переписывать все ручками, просто жми commit suggestions под ревью @BR54FF

@dj-34 dj-34 requested a review from Legendaxe December 3, 2023 21:57
@Legendaxe Legendaxe merged commit b7a033f into ss220club:translate Dec 3, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AyIong AyIong AyIong approved these changes

@Legendaxe Legendaxe Legendaxe approved these changes

@Gaxeer Gaxeer Gaxeer approved these changes

@dj-34 dj-34 dj-34 approved these changes

Assignees
No one assigned
Labels
:finnadie: НЕ МОДУЛЬНО Па-ху-ю. 📝 Перевод Приятно когда всё на родном языке.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BR54FF @dj-34 @Gaxeer @AyIong @Legendaxe