add: midround space wizards! #6023
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
code/modules/events/wizards.dm:36:error: GLOB.wizard_events_triggered: undefined var |
я заметил, да. |
Daeberdir
suggested changes
Oct 15, 2024
|
Ещё будет круто, если мы не будем мержить что-либо по протухшей предложке. |
Daeberdir
reviewed
Oct 15, 2024
Co-authored-by: Daeberdir <[email protected]>
Antoonij
reviewed
Nov 6, 2024
Comment on lines
+29
to
+33
| if(!candidates.len) | ||
| log_and_message_admins("Warning: Could not spawn any mobs for event Wizard Raid. Reason - not enough candidates.") | ||
| var/datum/event_container/EC = SSevents.event_containers[EVENT_LEVEL_MAJOR] | ||
| EC.next_event_time = world.time + (60 SECONDS) | ||
|
|
There was a problem hiding this comment.
раз уж нет кандидатов, то в конце твоих манипуляций с кулдауном нужно поставить return
Comment on lines
+34
to
+41
| while(mages_number && length(candidates)) | ||
| var/mob/new_mage = pick_n_take(candidates) | ||
| if(new_mage) | ||
| GLOB.wizard_events_triggered += 1 | ||
| var/mob/living/carbon/human/new_character= makeBody(new_mage) | ||
| new_character.mind.make_Wizard() // This puts them at the wizard spawn, worry not | ||
| mages_number-- | ||
| log_game("Spawned [new_character] (ckey: [new_character.key]) as midround Wizard.") |
There was a problem hiding this comment.
учитывая прошлый комментарий - это легче и лучше будет переписать на for
Antoonij
reviewed
Nov 6, 2024
| var/mob/new_mage = pick_n_take(candidates) | ||
| if(new_mage) | ||
| GLOB.wizard_events_triggered += 1 | ||
| var/mob/living/carbon/human/new_character= makeBody(new_mage) |
There was a problem hiding this comment.
Suggested change
| var/mob/living/carbon/human/new_character= makeBody(new_mage) | |
| var/mob/living/carbon/human/new_character = makeBody(new_mage) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
В случае, если на станции больше 10 живых игроков, то в качестве мажорного ивента начинают роллиться космические маги. Подсчет - один маг за каждые 30 человек. При триггере ивента блокируется возможность использовать часть заклинаний, привязанных к режиму "рагин магес".
Ссылка на предложение/Причина создания ПР
https://discord.com/channels/617003227182792704/755125334097133628/1225661296423473152
Пересозданная предложка
https://discord.com/channels/617003227182792704/755125334097133628/1297625539615522867
Тесты