Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial pass at resolving ruff issues #289

Closed
wants to merge 1 commit into from
Closed

Conversation

pyth0n1c
Copy link
Contributor

Tons of changes, many of them small (like resolving unused imports or variables) but great code cleanup.
This effort is motivated by the following PR to add ruff support in CI/CD: #254

However, because there are so many changes, maybe they should be made after the PR backlog has been cleared out?

This does not begin to address formatting issues, just things like bad imports, unused variables, etc.

@ljstella
Copy link
Contributor

I would agree- clearing the PR backlog first will make this easier so we won't have to spend even more time potentially clearing conflicts in every open PR.

I am open to doing this in two stages where we enforce the linter first and then fast-follow w/ the formatter if that means getting the first one of these changes (this one) in faster.

@pyth0n1c
Copy link
Contributor Author

I would agree- clearing the PR backlog first will make this easier so we won't have to spend even more time potentially clearing conflicts in every open PR.

I am open to doing this in two stages where we enforce the linter first and then fast-follow w/ the formatter if that means getting the first one of these changes (this one) in faster.

I agree.
The takeaway is that this PR only took maybe 30 minutes to throw together, so the initial pass of changes will be pretty easier!
Easier than keeping this PR up to date as we merge changes. I am closing this out - we will reopen a PR later with all the changes rather than continuously update this one.

@pyth0n1c pyth0n1c closed this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants