First crack at default config for ruff
#254
Conversation
ljstella
changed the title
ruff
pyproject.toml
Outdated
| line-length = 88 | ||
| indent-width = 4 | ||
|
|
||
| # Assume Python 3.8 |
There was a problem hiding this comment.
Let's make this 3.11, since that is currently the minimum version required for installing contentctl
There was a problem hiding this comment.
nit: can we update the comment too to reflect 3.11? I know the version itself has been changed already
pyproject.toml
Outdated
| line-length = 88 | ||
| indent-width = 4 | ||
|
|
||
| # Assume Python 3.8 |
There was a problem hiding this comment.
nit: can we update the comment too to reflect 3.11? I know the version itself has been changed already
|
I've added a pre-commit hook & CI job to this PR. If you want to review the output of the lint job you can see the current errors, or you can run them locally to see the output. I have the pre-commit hook set to automatically fix lints when possible. Not all of our existing lint issues are auto-fixable, but the vast majority are. I am considering adding E721 to the exclusion list, or at least inline-excluding the several issues in contentctl.py and would like your thoughts on this. @pyth0n1c in particular- I've not committed the mass-format and mass-lint-fix changes to this branch, you're more than welcome to add them if you'd like, I imagine you want to wrap some of the other existing open PRs so we don't create a massive merge-conflict headache on every single open PR. |
|
See the following first pass PR at resolving these: Should we hold off on all these changes until we clear the PR backlog? |
Creating first rough draft PR after conversation w/ Eric about getting this started in a new branch.
Rough draft of the default settings and whatnot for implementing
ruffas a linter & formatter. We'll need to take some time to go through the formatting, and the lints, and see what we do and don't want to turn on.TODO: