Add Take for REEArray #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert3005
commented
Mar 28, 2024
| }) | ||
| .collect::<VortexResult<Vec<_>>>()? | ||
| }); | ||
| take(self.values(), &PrimitiveArray::from(physical_indices)) |
There was a problem hiding this comment.
This is the same pattern that happens in Dict array, repeated value take on some dictionary.
lwwmanning
approved these changes
Mar 28, 2024
gatesn
reviewed
Mar 28, 2024
| impl TakeFn for REEArray { | ||
| fn take(&self, indices: &dyn Array) -> VortexResult<ArrayRef> { | ||
| let primitive_indices = flatten_primitive(indices)?; | ||
| let physical_indices = match_each_integer_ptype!(primitive_indices.ptype(), |$P| { |
There was a problem hiding this comment.
I think this should just be a search_sorted? Possibly this? #164
There was a problem hiding this comment.
That said, an iterator would allow us to apply the offset inline without allocating a new buffer
There was a problem hiding this comment.
This is just search sorted. That’s what find_physical_index does
There was a problem hiding this comment.
Yeah, but a lot of function calls, vs search_sorted_many
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.