Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLA-1310/1311: Changes to accommodate an IR time-dependent IMPHTTAB #621

Merged
merged 3 commits into from
Sep 3, 2024
Merged

HLA-1310/1311: Changes to accommodate an IR time-dependent IMPHTTAB #621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b65f76b
Rebase with latest on master and replaced spaces with tab.
mdlpstsci Apr 16, 2024
4076133
Forgot to fix the spaces vs tab for comment too
mdlpstsci Apr 16, 2024
cd067fa
Allow MJD as a parameterized variable for the PHOTMODE keyword to
mdlpstsci Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pkg/wfc3/Dates
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
15-Apr-2024 - MDD = Version 3.7.2
- Allow MJD as a parameterized variable for the PHOTMODE keyword to
enable a time-dependent photometric correction for the IR detector.
This supplements the change done for the UVIS in 2020 (Version 3.5.2).

18-Oct-2023 - MDD - Version 3.7.1
- Updates to reconcile the old and new algorithms for flagging full-well saturated pixels.
The new algorithm uses a saturation image which is applied after BLECORR/BIASCORR, and
Expand Down
5 changes: 5 additions & 0 deletions pkg/wfc3/History
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
### 15-Apr-2024 - MDD - Version 3.7.2
- Allow MJD as a parameterized variable for the PHOTMODE keyword to
enable a time-dependent photometric correction for the IR detector.
This supplements the change done for the UVIS in 2020 (Version 3.5.2).

### 18-Oct-2023 - MDD - Version 3.7.1
- Updates to reconcile the old and new algorithms for flagging full-well saturated pixels.
The new algorithm uses a saturation image which is applied after BLECORR/BIASCORR, and
Expand Down
5 changes: 5 additions & 0 deletions pkg/wfc3/Updates
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
Updates for Version 3.7.2 15-Apr-2024 - MDD
- Allow MJD as a parameterized variable for the PHOTMODE keyword to
enable a time-dependent photometric correction for the IR detector.
This supplements the change done for the UVIS in 2020 (Version 3.5.2).

Updates for Version 3.7.1 18-Oct-2023 - MDD
- Updates to reconcile the old and new algorithms for flagging full-well saturated pixels.
The new algorithm uses a saturation image which is applied after BLECORR/BIASCORR, and
Expand Down
4 changes: 2 additions & 2 deletions pkg/wfc3/include/wf3version.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
/* This string is written to the output primary header as CAL_VER. */


# define WF3_CAL_VER "3.7.1 (Oct-18-2023)"
# define WF3_CAL_VER_NUM "3.7.1"
# define WF3_CAL_VER "3.7.2 (Apr-15-2024)"
# define WF3_CAL_VER_NUM "3.7.2"

#endif /* INCL_WF3VERSION_H */
12 changes: 8 additions & 4 deletions pkg/wfc3/lib/wf32d/photmode.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@
for IR exposures because they're now in units of electrons.
M.De La Pena, 2020 Feb 28:
Added MJD in order to enable a time-dependent photometric correction.
M.De La Pena, 2024 Apr 15:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean April 15?

Copy link
Contributor Author

@mdlpstsci mdlpstsci Aug 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stscirij Yes. It is when I actually made the change!

Allow the 'MJD#' value to be added to the PHOTMODE keyword in order to
enable a time-dependent photometric correction for the IR. This supplements
the change done previously for the UVIS in 2020.
*/

int PhotMode (WF3Info *wf32d, Hdr *hdr) {
Expand Down Expand Up @@ -78,10 +82,10 @@ Hdr *hdr io: image header to be modified
strcat (photstr, wf32d->filter);
}

/* Add 'MJD#' keyword to PHOTMODE string for UVIS detector only */
if (wf32d->detector == CCD_DETECTOR)
sprintf (scratch, " MJD#%0.4f", wf32d->expstart);
strcat (photstr, scratch);
/* Update: Add 'MJD#' value to the PHOTMODE string for both the
UVIS and IR detectors */
sprintf (scratch, " MJD#%0.4f", wf32d->expstart);
strcat (photstr, scratch);

if (wf32d->verbose) {
sprintf (MsgText, "Keyword PHOTMODE built as: %s", photstr);
Expand Down
Loading