HLA-1310/1311: Changes to accommodate an IR time-dependent IMPHTTAB #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enable a time-dependent photometric correction for the IR detector. This supplements the change done for the UVIS in 2020 (Version 3.5.2).
|
IR regression tests running on Jenkins (#36) |
stscirij
reviewed
Aug 28, 2024
| @@ -39,6 +39,10 @@ | |||
| for IR exposures because they're now in units of electrons. | |||
| M.De La Pena, 2020 Feb 28: | |||
| Added MJD in order to enable a time-dependent photometric correction. | |||
| M.De La Pena, 2024 Apr 15: | |||
There was a problem hiding this comment.
@stscirij Yes. It is when I actually made the change!
stscirij
approved these changes
Aug 28, 2024
|
@stscirij |
mdlpstsci
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow MJD as a parameterized variable for the PHOTMODE keyword to enable a time-dependent photometric correction for the IR detector. This change supplements the change done for the UVIS in 2020 (Version 3.5.2).
Regression tests for the WFC3 IR change were successfully run here as the RAW an TRUTH files were updated appropriately: https://plwishmaster.stsci.edu:8081/job/RT/job/HSTCAL-Developers-Pull-Requests/39/consoleText
Any ACS failures are because the RAW and TRUTH files were also updates to accommodate the ACS serial CTE update where the team needs to give the final approval.