Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add performance tracing #204

Merged
merged 28 commits into from
Sep 9, 2024
Merged

Add performance tracing #204

merged 28 commits into from
Sep 9, 2024

Conversation

ehpor
Copy link
Collaborator

@ehpor ehpor commented May 22, 2024 •
edited
Loading

image

(https://ui.perfetto.dev/ with trace_1716350249429102200.json )

On simulation.

  • Do one test on hardware.
  • Test if Ctrl+C still works, since for some reason it doesn't on my Windows desktop (but develop does the same thing, so it might be something on my installation).

Fixes #19

@ehpor ehpor added the enhancement New feature or request label May 22, 2024
@ehpor ehpor self-assigned this May 22, 2024
@ehpor ehpor marked this pull request as draft May 22, 2024 16:29
@ehpor ehpor force-pushed the feature/performance_tracing branch from 12746de to 2eb82da Compare August 8, 2024 08:32
@ehpor ehpor mentioned this pull request Aug 23, 2024
Merged
@ehpor
Refactor tracing with smaller structures.
ec86075 
Move serialization into message loop for performance reasons.
Add instant event.
@ehpor
Add protobuf conversion for all trace events.
a651235
@ehpor
Add Python bindings and convenience functions for tracing proxy.
a5507bc
@ehpor
Temporarily disable printing of log messages.
93a7cc4 
Cuz I'm reusing this for forwarding trace event as well.
@ehpor
Start trace event distributor to testbed.
01416e7
@ehpor
Add temporary example for testing tracing.
543e740
@ehpor
Extract and generalize the LogDistributor into a ZmqDistributor.
d624b70
@ehpor
Enable connecting/disconnecting outside of the constructor/destructor.
8c6c886
@ehpor
Don't reconnect to the same host/port combination.
2670b61
@ehpor
Fix bindings for tracing proxy constructor change.
c0a8527
@ehpor
Refactor to enable global access to trace.
a637c1a 
From both C++ and Python.
@ehpor
Include process ID in counter traces.
1edac93
@ehpor
Rename tracing C++ file.
37d2811
@ehpor
Add process and thread name to traces.
be1d665
@ehpor
Add tracing for data streams.
b4f4d75
@ehpor
Add docstrings.
d2b9caf
@ehpor
Remove unused import.
a327523
@ehpor
Add actual trace test script.
edb1dbe
@ehpor
Make sure that trace events are not logged before connected.
d54dba6
@ehpor
Make sure the ZmqDistributor is running as expected after start is ca…
c2d8b29 
…lled.
@ehpor
Increase sleep times for windows slow-joiner problems.
07bf4b0
@ehpor
Use non-hardcoded ports for trace distribution.
56606bb
@ehpor ehpor force-pushed the feature/performance_tracing branch from 52ead5a to 56606bb Compare August 29, 2024 18:23
@ehpor
Copy link
Collaborator Author

ehpor commented Aug 29, 2024

First test on hardware:
image

@ehpor ehpor mentioned this pull request Aug 29, 2024
Merged
@ehpor ehpor marked this pull request as ready for review August 29, 2024 22:13
@ehpor ehpor merged commit a88f7ad into develop Sep 9, 2024
6 checks passed
@ehpor ehpor deleted the feature/performance_tracing branch September 9, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivalaginja ivalaginja ivalaginja approved these changes

@RemiSoummer RemiSoummer Awaiting requested review from RemiSoummer

@steigersg steigersg Awaiting requested review from steigersg

Assignees

@ehpor ehpor

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Performance tracing
2 participants
@ehpor @ivalaginja