Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix testbed port numbers #239

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Fix testbed port numbers #239

merged 3 commits into from
Aug 29, 2024

Conversation

ehpor
Copy link
Collaborator

@ehpor ehpor commented Aug 23, 2024 •
edited
Loading

Testbed port numbers were hardcoded in some places. This PR fixes that.

Fixes #240
Required for #204

@ehpor ehpor requested a review from steigersg August 23, 2024 21:04
@ehpor ehpor self-assigned this Aug 23, 2024
@ehpor ehpor marked this pull request as ready for review August 23, 2024 21:41
steigersg
steigersg approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@steigersg steigersg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - I can't speak much to the C code since I'm less familiar with it, but nothing jumps out as concerning.

@ehpor ehpor merged commit a0a5824 into develop Aug 29, 2024
12 checks passed
@ehpor ehpor deleted the bugfix/testbed_ports branch August 29, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steigersg steigersg steigersg approved these changes

Assignees

@ehpor ehpor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testbed port numbers are hardcoded and not retrieved from the testbed
2 participants
@ehpor @steigersg