Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable base Athena POC integration (take 2) #6379

Merged
merged 10 commits into from
Oct 8, 2024
Merged

Stable base Athena POC integration (take 2) #6379

merged 10 commits into from
Oct 8, 2024

Conversation

lrettig
Copy link
Member

@lrettig lrettig commented Oct 8, 2024

Replaces #6180

Motivation

Quick-and-dirty Athena POC integration, sufficient to run a go-spacemesh-based testnet with Athena as its only VM.

Description

  • brings in compiled Athena module
  • adds an Athena-based vm module
  • augments the existing account data type with 32-byte key/value storage slots

Non-goals: This POC is not intended to be merged into mainline go-spacemesh. It's not intended to be kept fully up to date with go-spacemesh fixes and releases, as it's only intended for testnet usage. We don't intend to maintain the existing genvm in this branch.

Test Plan

tbd

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

in Makefile for linux-arm64
One bugfix, and disable a few more tests
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 26.86567% with 588 lines in your changes missing coverage. Please review.

Please upload report for BASE (athena-poc@ad1026d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
vm/vm.go 7.1% 313 Missing ⚠️
vm/rewards.go 0.0% 63 Missing ⚠️
vm/core/context.go 58.8% 49 Missing and 9 partials ⚠️
vm/sdk/wallet/tx.go 0.0% 39 Missing ⚠️
vm/templates/wallet/handler.go 16.6% 20 Missing ⚠️
vm/host.go 69.6% 16 Missing and 1 partial ⚠️
vm/core/gas.go 0.0% 13 Missing ⚠️
sql/accounts/accounts.go 63.6% 8 Missing and 4 partials ⚠️
vm/templates/wallet/wallet.go 54.5% 10 Missing ⚠️
vm/core/hash.go 35.7% 9 Missing ⚠️
... and 6 more
Additional details and impacted files
@@             Coverage Diff              @@
##             athena-poc   #6379   +/-   ##
============================================
  Coverage              ?   80.3%           
============================================
  Files                 ?     328           
  Lines                 ?   35765           
  Branches              ?       0           
============================================
  Hits                  ?   28752           
  Misses                ?    5153           
  Partials              ?    1860           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@poszu poszu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left some nits

common/types/account_storage.go Outdated Show resolved Hide resolved
vm/templates/script/rust-toolchain Outdated Show resolved Hide resolved
vm/templates/script/Cargo.toml Outdated Show resolved Hide resolved
@lrettig lrettig merged commit 6515853 into athena-poc Oct 8, 2024
14 checks passed
@lrettig lrettig deleted the athena-poc2 branch October 8, 2024 21:11
@lrettig lrettig added the area/vm label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants