Proof of concept Athena VM integration

[lrettig]

Motivation

Quick-and-dirty Athena POC integration, sufficient to run a go-spacemesh-based testnet with Athena as its only VM.

Description

• brings in compiled Athena module
• replaces the existing genvm with Athena
• augments the existing account data type with 32-byte key/value storage slots

Non-goals: This POC is not intended to be merged into mainline go-spacemesh. It's not intended to be kept fully up to date with go-spacemesh fixes and releases, as it's only intended for testnet usage. We don't intend to maintain the existing genvm in this branch.

Test Plan

tbd

TODO

• Explain motivation or link existing issue(s)
• Test changes and document test plan
• Update documentation as needed
• Update changelog as needed

[codecov]

Codecov Report

Attention: Patch coverage is 78.33935% with 180 lines in your changes missing coverage. Please review.

Project coverage is 81.6%. Comparing base (f5f96b9) to head (82f9523).
Report is 3 commits behind head on develop.

Files with missing lines	Patch %	Lines
vm/vm.go	74.0%	69 Missing and 26 partials ⚠️
vm/core/context.go	75.1%	23 Missing and 12 partials ⚠️
vm/host.go	74.5%	12 Missing and 1 partial ⚠️
vm/rewards.go	84.1%	6 Missing and 4 partials ⚠️
vm/sdk/encode.go	0.0%	8 Missing ⚠️
vm/templates/wallet/handler.go	86.8%	4 Missing and 1 partial ⚠️
vm/core/staged_cache.go	84.6%	2 Missing and 2 partials ⚠️
vm/registry/registry.go	75.0%	1 Missing and 1 partial ⚠️
vm/sdk/wallet/address.go	66.6%	1 Missing and 1 partial ⚠️
vm/sdk/wallet/tx.go	95.1%	1 Missing and 1 partial ⚠️
... and 2 more

Additional details and impacted files

@@            Coverage Diff            @@
##           develop   #6180     +/-   ##
=========================================
- Coverage     81.8%   81.6%   -0.2%     
=========================================
  Files          312     327     +15     
  Lines        34603   35447    +844     
=========================================
+ Hits         28310   28957    +647     
- Misses        4458    4604    +146     
- Partials      1835    1886     +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[poszu]

I think we don't need script crate with the test harness. We can test the program crate using integration tests located under program/tests (they would run the program in a VM), wdyt?

[lrettig]

Right, this was copied over from the Athena side, right? It belongs there, not here

[poszu]

How about moving common and program into the vm/templates/wallet/ directory?

[lrettig]

"program" should probably become "wallet" (right? it's the wallet template), but there's currently another folder with that name. Let's sort out the existing Go code a little better before re-arranging these.

[lrettig]

Questions:

• where do we want to compute the principal, in athena or in go-sm? I think this could be either. If in athena, we need an interface for this.
• does the nonce live inside the athena tx payload or outside? (this was brought up before but we didn't reach a final answer: https://community.spacemesh.io/t/proposed-athena-design/433#questions-14) If inside, we need an interface for this.
• where do we do gas computations, in athena or in go-sm? Assuming in athena, then we need an interface that, given a TX payload and target address + method, calculates the max gas.
• where/how do we handle encoding of the athena tx payload? (These are the parts labeled ENCODE(...) in this post.) Assuming we want this logic to live entirely inside athena, we need an interface for this, too.

[lrettig]

Closing in favor of #6379