Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mob collisions #34580

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

metalgearsloth
Copy link
Contributor

@metalgearsloth metalgearsloth commented Jan 22, 2025

Title.

Currently POC stage but it should work with prediction.

2025-01-23.00-56-23.mp4

A later video though I polished it a bit from here and am happy.

2025-01-26.17-04-48.mp4

Requires space-wizards/RobustToolbox#5560

Changelog

  • add: Added mob collisions so you can no longer walk inside people.

@github-actions github-actions bot added size/M Denotes a PR that changes 100-999 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 22, 2025
@AgentePanela
Copy link

can you make a cvar?

@ArtisticRoomba ArtisticRoomba added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content D2: Medium Difficulty: A good amount of codebase knowledge required. A: General Interactions Area: General in-game interactions that don't relate to another area. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 22, 2025
@Rinary1
Copy link
Contributor

Rinary1 commented Jan 22, 2025

What about the backlog, tikreit? Won't that cause problems?

@keronshb
Copy link
Contributor

Finally we can change riot shields after this is implemented.

Comment on lines 28 to 29
collisionLayer: (int) CollisionGroup.MidImpassable,
collisionMask: (int) CollisionGroup.MidImpassable);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should layer/mask be configurable on the component, so flying mobs could ignore ground mobs but still collide with other flying mobs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up using flammable as it's supposed to be a generic non-hard event subscriber though still not entirely happy with it.

If I ever get around to my planned collision layer refactor I might revisit it or if we have mobs that don't have flammable that also need pushing.

@ImRenQ
Copy link
Contributor

ImRenQ commented Jan 22, 2025

maints in 2025
maints

@K-Dynamic
Copy link
Contributor

Is it possible to walk through people while being pushed out like in FPS games?

@metalgearsloth metalgearsloth marked this pull request as ready for review January 27, 2025 05:42
@metalgearsloth
Copy link
Contributor Author

Ready for review

@ArtisticRoomba ArtisticRoomba added the S: Needs Review Status: Requires additional reviews before being fully accepted label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: General Interactions Area: General in-game interactions that don't relate to another area. D2: Medium Difficulty: A good amount of codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/M Denotes a PR that changes 100-999 lines. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants